Disable framebusting intervention

Disable framebusting intervention

As mentioned in the Intent thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Xi8-y4ySjA4/9_96y_F6CAAJ

This is breaking enough legitimate content that we want to rethink the strategy.
https://codereview.chromium.org/2392773002 is the work-in-process for that.

BUG=624061
Committed: https://crrev.com/b0646f36c67c5cda685755ad15a7570c16fc0855
Cr-Commit-Position: refs/heads/master@{#425733}

[Nate Chapin, 2016-10-12 22:37:58]

Description was changed from

==========
Disable framebusting interventiom

BUG=624061
==========

to

==========
Disable framebusting intervention

As mentioned in the Intent thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Xi8-y4ySjA4/9_96y_F6...

This is breaking enough legitimate content that we want to rethink the strategy.
https://codereview.chromium.org/2392773002 is the work-in-process for that.

BUG=624061
==========

[Nate Chapin, 2016-10-12 22:37:59]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 22:38:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 23:58:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 23:58:32]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-10-13 16:43:21]

japhet@chromium.org changed reviewers:
+ jochen@chromium.org

[Nate Chapin, 2016-10-13 16:43:22]

This was reverted due to a layout test that depends on the framebusting
intervention, so I've marked that test failing and will "fix" it when the
intervention is re-enabled. Is that reasonable?

[jochen (gone - plz use gerrit), 2016-10-14 09:09:51]

On 2016/10/13 at 16:43:22, japhet wrote:
> This was reverted due to a layout test that depends on the framebusting
intervention, so I've marked that test failing and will "fix" it when the
intervention is re-enabled. Is that reasonable?

alternatively, the layout test could turn on the feature via window.internals,
no?

[Nate Chapin, 2016-10-14 19:45:38]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[Nate Chapin, 2016-10-14 19:45:39]

On 2016/10/14 at 09:09:51, jochen wrote:
> On 2016/10/13 at 16:43:22, japhet wrote:
> > This was reverted due to a layout test that depends on the framebusting
intervention, so I've marked that test failing and will "fix" it when the
intervention is re-enabled. Is that reasonable?
> 
> alternatively, the layout test could turn on the feature via window.internals,
no?

I probably should've figured that RuntimeEnabledFeatures could be set from
internals, but...I didn't. Thanks, done.

[jochen (gone - plz use gerrit), 2016-10-17 09:49:17]

lgtm

[Nate Chapin, 2016-10-17 17:22:35]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2016-10-17 17:23:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 18:49:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-17 18:51:37]

Description was changed from

==========
Disable framebusting intervention

As mentioned in the Intent thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Xi8-y4ySjA4/9_96y_F6...

This is breaking enough legitimate content that we want to rethink the strategy.
https://codereview.chromium.org/2392773002 is the work-in-process for that.

BUG=624061
==========

to

==========
Disable framebusting intervention

As mentioned in the Intent thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Xi8-y4ySjA4/9_96y_F6...

This is breaking enough legitimate content that we want to rethink the strategy.
https://codereview.chromium.org/2392773002 is the work-in-process for that.

BUG=624061

Committed: https://crrev.com/b0646f36c67c5cda685755ad15a7570c16fc0855
Cr-Commit-Position: refs/heads/master@{#425733}
==========

[commit-bot: I haz the power, 2016-10-17 18:51:38]

Patchset 2 (id:??) landed as
https://crrev.com/b0646f36c67c5cda685755ad15a7570c16fc0855
Cr-Commit-Position: refs/heads/master@{#425733}