ash/public/interfaces/wallpaper.mojom - Issue 2413503002: Cleanup mojo Wallpaper interfaces for mash.

Side by Side Diff: ash/public/interfaces/wallpaper.mojom

Issue 2413503002: Cleanup mojo Wallpaper interfaces for mash. (Closed)

Patch Set: Sync and rebase; do *not* use mojo in classic ash. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« ash/common/wallpaper/wallpaper_controller.cc ('K') | « ash/public/interfaces/typemaps.gni ('k') | ash/public/interfaces/wallpaper.typemap » ('j') | chrome/browser/chromeos/customization/customization_wallpaper_downloader_browsertest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module ash.mojom;	5 module ash.mojom;

6	6

7 import "skia/public/interfaces/bitmap.mojom";	7 import "skia/public/interfaces/bitmap.mojom";

8	8

9 // These values match wallpaper::WallpaperLayout.	9 // These values match wallpaper::WallpaperLayout.

10 enum WallpaperLayout { CENTER, CENTER_CROPPED, STRETCH, TILE, };	10 enum WallpaperLayout { CENTER, CENTER_CROPPED, STRETCH, TILE, };

11	11

12 // Used by Chrome to set the wallpaper displayed by ash.	12 // Used by Chrome to set the wallpaper displayed by ash.

13 interface WallpaperController {	13 interface WallpaperController {

14 SetWallpaper(skia.mojom.Bitmap? wallpaper, WallpaperLayout layout);	14 SetWallpaper(skia.mojom.Bitmap? wallpaper, WallpaperLayout layout);

	15 GetWallpaper() => (skia.mojom.Bitmap? wallpaper, WallpaperLayout layout);
	James Cook 2016/10/14 21:58:02 Document all mojom functions. In this case the mos Document all mojom functions. In this case the most interesting bit is what it means to receive a null bitmap. (Also, if I'm just reading the interface it's a little odd that Chrome would need to read back the wallpaper.) msw 2016/10/17 22:22:47 Done; documented Set and removed Get. Show quoted text On 2016/10/14 21:58:02, James Cook wrote: > Document all mojom functions. In this case the most interesting bit is what it > means to receive a null bitmap. > > (Also, if I'm just reading the interface it's a little odd that Chrome would > need to read back the wallpaper.) Done; documented Set and removed Get.
15 };	16 };

16	17

17 // Used by ash to trigger Chrome's wallpaper picker functionality.	18 // Used by ash to trigger Chrome's wallpaper picker functionality.

18 interface WallpaperManager {	19 interface WallpaperManager {
	James Cook 2016/10/14 21:58:02 aside: When reading other parts of the code it's n aside: When reading other parts of the code it's not immediately apparent which direction the communication is for WallpaperManager vs. WallpaperController. Maybe in another CL WallpaperManager should become WallpaperControllerClient? msw 2016/10/17 22:22:47 Perhaps; the WallpaperManager class and its Wallpa Show quoted text On 2016/10/14 21:58:02, James Cook wrote: > aside: When reading other parts of the code it's not immediately apparent which > direction the communication is for WallpaperManager vs. WallpaperController. > Maybe in another CL WallpaperManager should become WallpaperControllerClient? Perhaps; the WallpaperManager class and its WallpaperManagerBase base class do quite a lot; I'm not sure it makes sense to simply label the Chrome impl as a client of the WallpaperController interface, but yeah, the naming isn't ideal.
19 Open();	20 Open();

20 };	21 };

OLD	NEW