Issue 24135003: Update upload.py at b7cdf3e63c5e.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24135003: Update upload.py at b7cdf3e63c5e. (Closed)

Created:
7 years, 3 months ago by M-A Ruel

Modified:
7 years, 3 months ago

Reviewers:
iannucci, chrisphan

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, chrisphan

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

Description

Update upload.py at b7cdf3e63c5e. R=iannucci@chromium.org BUG=23608 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=224175

Patch Set 1 #

Total comments: 2

Created: 7 years, 3 months ago

		Unified diffs	Side-by-side diffs	Stats (+40 lines, -21 lines)
	M	third_party/upload.py	View	5 chunks	+40 lines, -21 lines	2 comments

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

iannucci

lgtm +1 comment for upstream https://codereview.chromium.org/24135003/diff/1/third_party/upload.py File third_party/upload.py (right): https://codereview.chromium.org/24135003/diff/1/third_party/upload.py#newcode1618 third_party/upload.py:1618: universal_newlines=False) isn't universal_newlines=False the ...

7 years, 3 months ago (2013-09-19 17:25:19 UTC) #2

chrisphan

https://codereview.chromium.org/24135003/diff/1/third_party/upload.py File third_party/upload.py (right): https://codereview.chromium.org/24135003/diff/1/third_party/upload.py#newcode1618 third_party/upload.py:1618: universal_newlines=False) On 2013/09/19 17:25:20, iannucci wrote: > isn't universal_newlines=False ...

7 years, 3 months ago (2013-09-19 17:45:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/24135003/1

7 years, 3 months ago (2013-09-19 18:48:37 UTC) #4

Message was sent while issue was closed.

Change committed as 224175

Expand Messages | Collapse Messages