Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2413423003: fix skslc crashes uncovered by fuzz testing (Closed)

Created:
4 years, 2 months ago by ethannicholas
Modified:
4 years, 2 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix skslc crashes uncovered by fuzz testing BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2413423003 Committed: https://skia.googlesource.com/skia/+/a54401da547def2e6e058df3ee2a03a843fb40ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M src/sksl/SkSLIRGenerator.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/sksl/SkSLParser.cpp View 1 chunk +14 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ethannicholas
4 years, 2 months ago (2016-10-14 14:26:07 UTC) #3
dogben
lgtm
4 years, 2 months ago (2016-10-14 14:53:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413423003/1
4 years, 2 months ago (2016-10-14 14:59:43 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 15:37:34 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a54401da547def2e6e058df3ee2a03a843fb40ae

Powered by Google App Engine
This is Rietveld 408576698