Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2413423002: Add Precache.CacheStatus.NonPrefetch.FromPrecache. (Closed)

Created:
4 years, 2 months ago by twifkak
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Add Precache.CacheStatus.NonPrefetch.FromPrecache. This UMA is like Precache.CacheStatus.NonPrefetch, but only for requests where the URL matches an unused entry in the precache_urls table -- that is, first requests for URLs retrieved as part of prefetching. Misses would be reported by this metric as a result of expiration or eviction. Changed PrecacheURLTable::Is*URL*() methods with varying WHERE clauses to PrecacheURLTable::GetURLInfo() and a PrecacheURLInfo struct containing the SELECTed columns. This allows us to report this metric not just for first requests for precached URLs (i.e. where is_precached = 1), but for all such requests. This should cause the metrics sampled to be weighted similarly to HttpCache.Pattern. BUG=650773 Review-Url: https://codereview.chromium.org/2364873004 Cr-Commit-Position: refs/heads/master@{#423892} (cherry picked from commit 25783a2fecb69d613b1f3cfa9ea9e347b87887de) Committed: https://chromium.googlesource.com/chromium/src/+/f3426a9beee6d0bdf664ece23c26e3d452c96123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -31 lines) Patch
M components/precache/content/precache_manager_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/precache/core/precache_database.cc View 3 chunks +11 lines, -6 lines 0 comments Download
M components/precache/core/precache_database_unittest.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M components/precache/core/precache_url_table.h View 2 chunks +19 lines, -5 lines 0 comments Download
M components/precache/core/precache_url_table.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M components/precache/core/precache_url_table_unittest.cc View 2 chunks +26 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
twifkak
4 years, 2 months ago (2016-10-13 22:33:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f3426a9beee6d0bdf664ece23c26e3d452c96123.

Powered by Google App Engine
This is Rietveld 408576698