Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2413403002: Allow new public names in patches for the dart:_internal library. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow new public names in patches for the dart:_internal library. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4c065c84438b04772608ed71d3e7257782e0dfe6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -5 lines) Patch
M pkg/analyzer/lib/src/dart/sdk/patch.dart View 5 chunks +10 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/dart/sdk/patch_test.dart View 2 chunks +42 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 2 months ago (2016-10-13 21:42:51 UTC) #1
Paul Berry
lgtm
4 years, 2 months ago (2016-10-13 21:49:28 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 4c065c84438b04772608ed71d3e7257782e0dfe6 (presubmit successful).
4 years, 2 months ago (2016-10-13 21:52:28 UTC) #4
Brian Wilkerson
4 years, 2 months ago (2016-10-13 22:21:16 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698