Issue 2413293002: Patch token stream when replace/add nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2413293002: Patch token stream when replace/add nodes. (Closed)

Created:
4 years, 2 months ago by scheglov

Modified:
4 years, 2 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Patch token stream when replace/add nodes. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0ae79f6f4b628451ff9674ae5446117354585dc8

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -22 lines)			Patch
	M	pkg/analyzer/lib/src/dart/sdk/patch.dart	View		3 chunks	+29 lines, -4 lines	0 comments	Download
	M	pkg/analyzer/test/src/dart/sdk/patch_test.dart	View		6 chunks	+59 lines, -18 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

Committed patchset #1 (id:1) manually as 0ae79f6f4b628451ff9674ae5446117354585dc8 (presubmit successful).

4 years, 2 months ago (2016-10-13 17:37:25 UTC) #4

Brian Wilkerson

I too am curious as to why this is necessary. But other than that, lgtm.

4 years, 2 months ago (2016-10-13 18:10:37 UTC) #5

scheglov

4 years, 2 months ago (2016-10-13 18:13:00 UTC) #6

Message was sent while issue was closed.

On 2016/10/13 18:10:37, Brian Wilkerson wrote:
> I too am curious as to why this is necessary. But other than that, lgtm.

We need to ensure that after patching both AST and token stream were consistent,
as if they were created from a single patched source file.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages