Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2413243002: Introduce a CompilerDispatcherTracer and track how long jobs take (Closed)

Created:
4 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 2 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce a CompilerDispatcherTracer and track how long jobs take R=ulan@chromium.org,cbruni@chromium.org,rmcilroy@chromium.org BUG=v8:5215 Committed: https://crrev.com/ad99b196cb8f53eddc34c7cf07cdf6608169105f Cr-Commit-Position: refs/heads/master@{#40295}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+425 lines, -52 lines) Patch
M BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
A src/base/ring-buffer.h View 1 chunk +54 lines, -0 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 8 chunks +11 lines, -0 lines 0 comments Download
A src/compiler-dispatcher/compiler-dispatcher-tracer.h View 1 1 chunk +97 lines, -0 lines 0 comments Download
A src/compiler-dispatcher/compiler-dispatcher-tracer.cc View 1 1 chunk +173 lines, -0 lines 0 comments Download
M src/counters.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/gc-tracer.h View 4 chunks +12 lines, -49 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/isolate.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 3 chunks +5 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download
M test/unittests/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/unittests/compiler-dispatcher/compiler-dispatcher-tracer-unittest.cc View 1 1 chunk +51 lines, -0 lines 0 comments Download
M test/unittests/heap/gc-tracer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/unittests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jochen (gone - plz use gerrit)
4 years, 2 months ago (2016-10-13 10:55:26 UTC) #1
jochen (gone - plz use gerrit)
Ulan, ptal
4 years, 2 months ago (2016-10-13 11:03:56 UTC) #4
ulan
lgtm https://codereview.chromium.org/2413243002/diff/1/src/compiler-dispatcher/compiler-dispatcher-tracer.h File src/compiler-dispatcher/compiler-dispatcher-tracer.h (right): https://codereview.chromium.org/2413243002/diff/1/src/compiler-dispatcher/compiler-dispatcher-tracer.h#newcode69 src/compiler-dispatcher/compiler-dispatcher-tracer.h:69: double EstimatePrepareToParse() const; nit: I would add *TimeInMs ...
4 years, 2 months ago (2016-10-13 16:56:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413243002/20001
4 years, 2 months ago (2016-10-14 07:15:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 08:12:23 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 08:12:52 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ad99b196cb8f53eddc34c7cf07cdf6608169105f
Cr-Commit-Position: refs/heads/master@{#40295}

Powered by Google App Engine
This is Rietveld 408576698