Issue 2413233004: Version 5.6.52.1 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2413233004: Version 5.6.52.1 (cherry-pick) (Closed)

Created:
4 years, 2 months ago by Michael Hablich

Modified:
4 years, 2 months ago

Reviewers:
Michael Achenbach

CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan, Hannes Payer (out of office), Paweł Hajdan Jr.

Target Ref:
refs/pending/heads/5.6.52

Project:
v8

Visibility:
Public.

Version 5.6.52.1 (cherry-pick) Merged cdc3459a858a6b86e96cedf841f7b95e49fef272 Revert of [heap] Move slot filtering logic into sweeper. (patchset #4 id:60001 of https://codereview.chromium.org/2418773002/ ) LOG=N TBR=machenbach@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/cd5ab72760027501bbe561476c0aa8b6bf8569d4

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -75 lines)			Patch
M	include/v8-version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap/mark-compact.cc	View	6 chunks	+8 lines, -20 lines	0 comments	Download
M	src/heap/remembered-set.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/heap/remembered-set.cc	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	src/heap/slot-set.h	View	4 chunks	+17 lines, -32 lines	0 comments	Download
M	test/unittests/heap/slot-set-unittest.cc	View	2 chunks	+16 lines, -22 lines	0 comments	Download

Total messages: 4 (1 generated)

Michael Hablich

Committed patchset #1 (id:1) manually as cd5ab72760027501bbe561476c0aa8b6bf8569d4.

4 years, 2 months ago (2016-10-14 10:08:35 UTC) #3

Message was sent while issue was closed.

lgtm