Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2413233002: Change Set.difference API to accept Set<Object>. (Closed)

Created:
4 years, 2 months ago by floitsch
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org, vsm, kevmoo
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change Set.difference API to accept Set<Object>. Fixes #27573 BUG= http://dartbug.com/27573 R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/6beb1fdd11d583c9b2a5ed850576e4c1c265a7ba

Patch Set 1 #

Patch Set 2 : Also update a few subclasses. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/helpers/debug_collection.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/helpers/expensive_set.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/util/emptyset.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/util/setlet.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/set.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/set_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
4 years, 2 months ago (2016-10-13 09:45:37 UTC) #2
Lasse Reichstein Nielsen
lgtm
4 years, 2 months ago (2016-10-13 11:32:54 UTC) #3
floitsch
4 years, 2 months ago (2016-10-20 12:37:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6beb1fdd11d583c9b2a5ed850576e4c1c265a7ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698