Allow anyone to change components_tests.gyp.

Allow anyone to change components_tests.gyp.

NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265357

R=blundell@chromium.org, jochen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266661

[jochen (gone - plz use gerrit), 2014-04-17 20:21:53]

On 2014/04/17 20:15:30, Vitaly Buka wrote:

I'd rather not do this. It's easy to get gyp changes wrong, so we usually don't
do this

[Vitaly Buka (NO REVIEWS), 2014-04-17 20:34:41]

On 2014/04/17 20:21:53, jochen (OOO until Apr 22) wrote:
> On 2014/04/17 20:15:30, Vitaly Buka wrote:
> 
> I'd rather not do this. It's easy to get gyp changes wrong, so we usually
don't
> do this

it's for unit tests only, chrome and contents even has per-file *.gypi=* 

i had no problems yet, but is it OK TBR if the last thins blocking CL is just
new test in components_tests.gyp ?

[jochen (gone - plz use gerrit), 2014-04-17 20:44:46]

On 2014/04/17 20:34:41, Vitaly Buka wrote:
> On 2014/04/17 20:21:53, jochen (OOO until Apr 22) wrote:
> > On 2014/04/17 20:15:30, Vitaly Buka wrote:
> > 
> > I'd rather not do this. It's easy to get gyp changes wrong, so we usually
> don't
> > do this
> 
> it's for unit tests only, chrome and contents even has per-file *.gypi=* 
> 
> i had no problems yet, but is it OK TBR if the last thins blocking CL is just
> new test in components_tests.gyp ?

Adding, removing, and renaming files is OK. Changing the structure, like adding
a new target or a dependency should get a review.

If you want to add this exception, there should be a similar comment like e.g.
in the content one

[Vitaly Buka (NO REVIEWS), 2014-04-18 23:45:15]

On 2014/04/17 20:44:46, jochen (OOO until Apr 22) wrote:
> On 2014/04/17 20:34:41, Vitaly Buka wrote:
> > On 2014/04/17 20:21:53, jochen (OOO until Apr 22) wrote:
> > > On 2014/04/17 20:15:30, Vitaly Buka wrote:
> > > 
> > > I'd rather not do this. It's easy to get gyp changes wrong, so we usually
> > don't
> > > do this
> > 
> > it's for unit tests only, chrome and contents even has per-file *.gypi=* 
> > 
> > i had no problems yet, but is it OK TBR if the last thins blocking CL is
just
> > new test in components_tests.gyp ?
> 
> Adding, removing, and renaming files is OK. Changing the structure, like
adding
> a new target or a dependency should get a review.
> 
> If you want to add this exception, there should be a similar comment like e.g.
> in the content one

Done.

[jochen (gone - plz use gerrit), 2014-04-22 06:58:07]

lgtm

[Vitaly Buka (NO REVIEWS), 2014-04-22 16:29:06]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-04-22 16:29:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/241323003/20001

[commit-bot: I haz the power, 2014-04-22 21:01:41]

Change committed as 265357

[blundell, 2014-04-28 08:20:55]

lgtm

I'm fine with this

https://codereview.chromium.org/241323003/diff/20001/components/OWNERS
File components/OWNERS (right):

https://codereview.chromium.org/241323003/diff/20001/components/OWNERS#newcod...
components/OWNERS:140: # structural changes, please get a review from a reviewer
in this file.
nit: s/"reviewer in this file"/"one of the overall components OWNERS"

[Vitaly Buka (NO REVIEWS), 2014-04-28 20:45:51]

https://codereview.chromium.org/241323003/diff/20001/components/OWNERS
File components/OWNERS (right):

https://codereview.chromium.org/241323003/diff/20001/components/OWNERS#newcod...
components/OWNERS:140: # structural changes, please get a review from a reviewer
in this file.
On 2014/04/28 08:20:55, blundell wrote:
> nit: s/"reviewer in this file"/"one of the overall components OWNERS"

Done.

[Vitaly Buka (NO REVIEWS), 2014-04-28 20:45:54]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-04-28 20:47:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/241323003/40001

[commit-bot: I haz the power, 2014-04-28 20:47:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 20:47:36]

Failed to apply patch for components/OWNERS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file components/OWNERS
  Hunk #1 FAILED at 143.
  1 out of 1 hunk FAILED -- saving rejects to file components/OWNERS.rej

Patch:       components/OWNERS
Index: components/OWNERS
diff --git a/components/OWNERS b/components/OWNERS
index
d7d7aa3e1b0a06d1a08a0984b58492ba8a979ada..1dbed916e21354592ab7e302cb41872f6773892f
100644
--- a/components/OWNERS
+++ b/components/OWNERS
@@ -143,6 +143,7 @@ per-file wifi.gypi=mef@chromium.org
 per-file *.isolate=csharp@chromium.org
 per-file *.isolate=maruel@chromium.org
 
-# These are for the common case of adding or removing test. If you're doing
-# structural changes, please get a review from a reviewer in this file. 
+# These are for the common case of adding or removing tests. If you're making
+# structural changes, please get a review from one of the overall components
+# OWNERS.
 per-file components_tests.gyp=*

[Vitaly Buka (NO REVIEWS), 2014-04-28 21:17:43]

Committed patchset #3 manually as r266661 (presubmit successful).