Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 2413223003: Views:: Make Labels support text selection. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/render_text_harfbuzz.h ('k') | ui/gfx/render_text_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_harfbuzz.cc
diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc
index 5269f4ac248d507f70ee74b54826d4387da8a564..e543bc5987583206686d593146fff9e6028f834b 100644
--- a/ui/gfx/render_text_harfbuzz.cc
+++ b/ui/gfx/render_text_harfbuzz.cc
@@ -845,6 +845,11 @@ SelectionModel RenderTextHarfBuzz::FindCursorPosition(const Point& point) {
return EdgeSelectionModel(CURSOR_RIGHT);
}
+bool RenderTextHarfBuzz::IsSelectionSupported() const {
+ // TODO(karandeepb): Support multi-line text selection.
+ return !multiline();
+}
+
std::vector<RenderText::FontSpan> RenderTextHarfBuzz::GetFontSpansForTesting() {
EnsureLayout();
« no previous file with comments | « ui/gfx/render_text_harfbuzz.h ('k') | ui/gfx/render_text_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698