Views:: Make Labels support text selection.

ui/views/controls/label_unittest.cc

Index: ui/views/controls/label_unittest.cc
diff --git a/ui/views/controls/label_unittest.cc b/ui/views/controls/label_unittest.cc
index f9ec47cbb3828142beee27c38be438d8301d7d67..c97139d97cc494667eb1dc9fe489461942f5dd73 100644
--- a/ui/views/controls/label_unittest.cc
+++ b/ui/views/controls/label_unittest.cc
@@ -11,8 +11,10 @@
 #include "build/build_config.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/accessibility/ax_view_state.h"
+#include "ui/base/clipboard/clipboard.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/compositor/canvas_painter.h"
+#include "ui/events/base_event_utils.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/render_text.h"
 #include "ui/views/border.h"
@@ -22,32 +24,93 @@
 
 using base::ASCIIToUTF16;
 
+#define EXPECT_STR_EQ(ascii, utf16) EXPECT_EQ(ASCIIToUTF16(ascii), utf16)
+
 namespace views {
-namespace {
 
-// All text sizing measurements (width and height) should be greater than this.
-const int kMinTextDimension = 4;
+class LabelTest : public ViewsTestBase {
+ public:
+  LabelTest() : label_(nullptr), widget_(nullptr) {}
 
-using LabelTest = ViewsTestBase;
+  // ::testing::Test:

[msw, 2016/11/01 23:42:22]

nit: cite the more direct base class (ViewsTestBase) instead.

[karandeepb, 2016/11/02 06:29:38]

Done.

+  void SetUp() override {
+    ViewsTestBase::SetUp();
 
-class LabelFocusTest : public FocusManagerTest {
- public:
-  LabelFocusTest() {}
-  ~LabelFocusTest() override {}
+    widget_ = new Widget;

[msw, 2016/11/01 23:42:22]

Avoid new and a raw pointer; use a plain member |Widget widget_;| or
std::unique_ptr and base::MakeUnique if really needed.

[karandeepb, 2016/11/02 06:29:38]

Done.

+    Widget::InitParams params =
+        CreateParams(Widget::InitParams::TYPE_WINDOW_FRAMELESS);
+    params.bounds = gfx::Rect(200, 200, 200, 200);

[msw, 2016/11/01 23:42:22]

q: are the bounds important or should they just be non-empty?
(maybe just use gfx::Rect(200, 200); for a size with 0,0 position?)

[karandeepb, 2016/11/02 06:29:38]

Done.

+    widget_->Init(params);
+    View* container = new View();
+    widget_->SetContentsView(container);
+
+    label_ = new Label();
+    container->AddChildView(label_);
+
+    widget_->Show();
+  }
+
+  void TearDown() override {
+    if (widget_)

[msw, 2016/11/01 23:42:22]

I don't see when widget_ would be null here; remove this check?

[karandeepb, 2016/11/02 06:29:38]

Done.

+      widget_->Close();

[msw, 2016/11/01 23:42:22]

nit: Use WIDGET_OWNS_NATIVE_WIDGET and skip this? Destruction should suffice.

[karandeepb, 2016/11/02 06:29:38]

Using WIDGET_OWNS_NATIVE_WIDGET since we are managing the Widget lifetime now.
Close is still necessary since there are checks to ensure that all windows are
closed during TearDown.

+
+    ViewsTestBase::TearDown();
+  }
 
  protected:
   Label* label() { return label_; }
 
- private:
-  // FocusManagerTest:
-  void InitContentView() override {
-    label_ = new views::Label();
-    GetContentsView()->AddChildView(label_);
+  Widget* widget() { return widget_; }
+
+  View* GetFocusedView() {
+    return widget()->GetFocusManager()->GetFocusedView();

[msw, 2016/11/01 23:42:22]

optional nit: inline this.

[karandeepb, 2016/11/02 06:29:38]

Keeping this. This is used multiple times. 

+  }
+
+  void PerformMousePress(const gfx::Point& point, int extra_flags = 0) {

[msw, 2016/11/01 23:42:22]

I wonder if it makes sense to use EventGenerator here?
(don't bother if that doesn't work right for unit tests)

[karandeepb, 2016/11/02 06:29:38]

This is easier to set up (Don't have to think about coordinates etc.) and since
we are just unit-testing the Label class and not the event propagation, this
should suffice. Tests for textfield/combobox also don't use EventGenerator for
mouse events.

+    ui::MouseEvent pressed_event = ui::MouseEvent(
+        ui::ET_MOUSE_PRESSED, point, point, ui::EventTimeForNow(),
+        ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON | extra_flags);
+    label()->OnMousePressed(pressed_event);
+  }
+
+  void PerformMouseRelease(const gfx::Point& point) {
+    ui::MouseEvent released_event = ui::MouseEvent(
+        ui::ET_MOUSE_RELEASED, point, point, ui::EventTimeForNow(),
+        ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON);
+    label()->OnMouseReleased(released_event);
+  }
+
+  void PerformClick(const gfx::Point& point, int extra_flags = 0) {
+    PerformMousePress(point, extra_flags);
+    PerformMouseRelease(point);
+  }
+
+  void DragMouseTo(const gfx::Point& point) {

[msw, 2016/11/01 23:42:22]

nit: name PerformMouseDragTo or similar for consistency.

[karandeepb, 2016/11/02 06:29:38]

Done.

+    ui::MouseEvent drag(ui::ET_MOUSE_DRAGGED, point, point,
+                        ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON, 0);
+    label()->OnMouseDragged(drag);
   }
 
+  gfx::Point GetCursorPoint(int cursor_pos) {
+    return label()
+        ->GetRenderTextForSelectionController()
+        ->GetCursorBounds(gfx::SelectionModel(cursor_pos, gfx::CURSOR_FORWARD),
+                          false)
+        .origin();
+  }
+
+ private:
   Label* label_;

[msw, 2016/11/01 23:42:22]

nit: |= nullptr| here to avoid initializer list.

[karandeepb, 2016/11/02 06:29:38]

Done.

+  Widget* widget_;
+
+  DISALLOW_COPY_AND_ASSIGN(LabelTest);
 };
 
+namespace {
+
+// All text sizing measurements (width and height) should be greater than this.
+const int kMinTextDimension = 4;
+
 class TestLabel : public Label {
  public:
   TestLabel() : Label(ASCIIToUTF16("TestLabel")) { SizeToPreferredSize(); }
@@ -85,6 +148,13 @@ bool Increased(int current, int* last) {
   return increased;
 }
 
+base::string16 GetSelectionClipboardText() {
+  base::string16 selection_clipboard_text;
+  ui::Clipboard::GetForCurrentThread()->ReadText(ui::CLIPBOARD_TYPE_SELECTION,
+                                                 &selection_clipboard_text);
+  return selection_clipboard_text;
+}
+
 }  // namespace
 
 // Crashes on Linux only. http://crbug.com/612406
@@ -94,64 +164,59 @@ bool Increased(int current, int* last) {
 #define MAYBE_FontPropertySymbol FontPropertySymbol
 #endif
 TEST_F(LabelTest, MAYBE_FontPropertySymbol) {
-  Label label;
   std::string font_name("symbol");
   gfx::Font font(font_name, 26);
-  label.SetFontList(gfx::FontList(font));
-  gfx::Font font_used = label.font_list().GetPrimaryFont();
+  label()->SetFontList(gfx::FontList(font));
+  gfx::Font font_used = label()->font_list().GetPrimaryFont();
   EXPECT_EQ(font_name, font_used.GetFontName());
   EXPECT_EQ(26, font_used.GetFontSize());
 }
 
 TEST_F(LabelTest, FontPropertyArial) {
-  Label label;
   std::string font_name("arial");
   gfx::Font font(font_name, 30);
-  label.SetFontList(gfx::FontList(font));
-  gfx::Font font_used = label.font_list().GetPrimaryFont();
+  label()->SetFontList(gfx::FontList(font));
+  gfx::Font font_used = label()->font_list().GetPrimaryFont();
   EXPECT_EQ(font_name, font_used.GetFontName());
   EXPECT_EQ(30, font_used.GetFontSize());
 }
 
 TEST_F(LabelTest, TextProperty) {
-  Label label;
   base::string16 test_text(ASCIIToUTF16("A random string."));
-  label.SetText(test_text);
-  EXPECT_EQ(test_text, label.text());
+  label()->SetText(test_text);
+  EXPECT_EQ(test_text, label()->text());
 }
 
 TEST_F(LabelTest, ColorProperty) {
-  Label label;
   SkColor color = SkColorSetARGB(20, 40, 10, 5);
-  label.SetAutoColorReadabilityEnabled(false);
-  label.SetEnabledColor(color);
-  EXPECT_EQ(color, label.enabled_color());
+  label()->SetAutoColorReadabilityEnabled(false);
+  label()->SetEnabledColor(color);
+  EXPECT_EQ(color, label()->enabled_color());
 }
 
 TEST_F(LabelTest, AlignmentProperty) {
   const bool was_rtl = base::i18n::IsRTL();
 
-  Label label;
   for (size_t i = 0; i < 2; ++i) {
     // Toggle the application default text direction (to try each direction).
     SetRTL(!base::i18n::IsRTL());
     bool reverse_alignment = base::i18n::IsRTL();
 
     // The alignment should be flipped in RTL UI.
-    label.SetHorizontalAlignment(gfx::ALIGN_RIGHT);
+    label()->SetHorizontalAlignment(gfx::ALIGN_RIGHT);
     EXPECT_EQ(reverse_alignment ? gfx::ALIGN_LEFT : gfx::ALIGN_RIGHT,
-              label.horizontal_alignment());
-    label.SetHorizontalAlignment(gfx::ALIGN_LEFT);
+              label()->horizontal_alignment());
+    label()->SetHorizontalAlignment(gfx::ALIGN_LEFT);
     EXPECT_EQ(reverse_alignment ? gfx::ALIGN_RIGHT : gfx::ALIGN_LEFT,
-              label.horizontal_alignment());
-    label.SetHorizontalAlignment(gfx::ALIGN_CENTER);
-    EXPECT_EQ(gfx::ALIGN_CENTER, label.horizontal_alignment());
+              label()->horizontal_alignment());
+    label()->SetHorizontalAlignment(gfx::ALIGN_CENTER);
+    EXPECT_EQ(gfx::ALIGN_CENTER, label()->horizontal_alignment());
 
     for (size_t j = 0; j < 2; ++j) {
-      label.SetHorizontalAlignment(gfx::ALIGN_TO_HEAD);
+      label()->SetHorizontalAlignment(gfx::ALIGN_TO_HEAD);
       const bool rtl = j == 0;
-      label.SetText(rtl ? base::WideToUTF16(L"\x5d0") : ASCIIToUTF16("A"));
-      EXPECT_EQ(gfx::ALIGN_TO_HEAD, label.horizontal_alignment());
+      label()->SetText(rtl ? base::WideToUTF16(L"\x5d0") : ASCIIToUTF16("A"));
+      EXPECT_EQ(gfx::ALIGN_TO_HEAD, label()->horizontal_alignment());
     }
   }
 
@@ -159,75 +224,71 @@ TEST_F(LabelTest, AlignmentProperty) {
 }
 
 TEST_F(LabelTest, ElideBehavior) {
-  Label label;
   base::string16 text(ASCIIToUTF16("This is example text."));
-  label.SetText(text);
-  EXPECT_EQ(gfx::ELIDE_TAIL, label.elide_behavior());
-  gfx::Size size = label.GetPreferredSize();
-  label.SetBoundsRect(gfx::Rect(size));
-  EXPECT_EQ(text, label.GetDisplayTextForTesting());
+  label()->SetText(text);
+  EXPECT_EQ(gfx::ELIDE_TAIL, label()->elide_behavior());
+  gfx::Size size = label()->GetPreferredSize();
+  label()->SetBoundsRect(gfx::Rect(size));
+  EXPECT_EQ(text, label()->GetDisplayTextForTesting());
 
   size.set_width(size.width() / 2);
-  label.SetBoundsRect(gfx::Rect(size));
-  EXPECT_GT(text.size(), label.GetDisplayTextForTesting().size());
+  label()->SetBoundsRect(gfx::Rect(size));
+  EXPECT_GT(text.size(), label()->GetDisplayTextForTesting().size());
 
-  label.SetElideBehavior(gfx::NO_ELIDE);
-  EXPECT_EQ(text, label.GetDisplayTextForTesting());
+  label()->SetElideBehavior(gfx::NO_ELIDE);
+  EXPECT_EQ(text, label()->GetDisplayTextForTesting());
 }
 
 TEST_F(LabelTest, MultiLineProperty) {
-  Label label;
-  EXPECT_FALSE(label.multi_line());
-  label.SetMultiLine(true);
-  EXPECT_TRUE(label.multi_line());
-  label.SetMultiLine(false);
-  EXPECT_FALSE(label.multi_line());
+  EXPECT_FALSE(label()->multi_line());
+  label()->SetMultiLine(true);
+  EXPECT_TRUE(label()->multi_line());
+  label()->SetMultiLine(false);
+  EXPECT_FALSE(label()->multi_line());
 }
 
 TEST_F(LabelTest, ObscuredProperty) {
-  Label label;
   base::string16 test_text(ASCIIToUTF16("Password!"));
-  label.SetText(test_text);
-  label.SizeToPreferredSize();
+  label()->SetText(test_text);
+  label()->SizeToPreferredSize();
 
   // The text should be unobscured by default.
-  EXPECT_FALSE(label.obscured());
-  EXPECT_EQ(test_text, label.GetDisplayTextForTesting());
-  EXPECT_EQ(test_text, label.text());
+  EXPECT_FALSE(label()->obscured());
+  EXPECT_EQ(test_text, label()->GetDisplayTextForTesting());
+  EXPECT_EQ(test_text, label()->text());
 
-  label.SetObscured(true);
-  label.SizeToPreferredSize();
-  EXPECT_TRUE(label.obscured());
+  label()->SetObscured(true);
+  label()->SizeToPreferredSize();
+  EXPECT_TRUE(label()->obscured());
   EXPECT_EQ(base::string16(test_text.size(),
                            gfx::RenderText::kPasswordReplacementChar),
-            label.GetDisplayTextForTesting());
-  EXPECT_EQ(test_text, label.text());
+            label()->GetDisplayTextForTesting());
+  EXPECT_EQ(test_text, label()->text());
 
-  label.SetText(test_text + test_text);
-  label.SizeToPreferredSize();
+  label()->SetText(test_text + test_text);
+  label()->SizeToPreferredSize();
   EXPECT_EQ(base::string16(test_text.size() * 2,
                            gfx::RenderText::kPasswordReplacementChar),
-            label.GetDisplayTextForTesting());
-  EXPECT_EQ(test_text + test_text, label.text());
+            label()->GetDisplayTextForTesting());
+  EXPECT_EQ(test_text + test_text, label()->text());
 
-  label.SetObscured(false);
-  label.SizeToPreferredSize();
-  EXPECT_FALSE(label.obscured());
-  EXPECT_EQ(test_text + test_text, label.GetDisplayTextForTesting());
-  EXPECT_EQ(test_text + test_text, label.text());
+  label()->SetObscured(false);
+  label()->SizeToPreferredSize();
+  EXPECT_FALSE(label()->obscured());
+  EXPECT_EQ(test_text + test_text, label()->GetDisplayTextForTesting());
+  EXPECT_EQ(test_text + test_text, label()->text());
 }
 
 TEST_F(LabelTest, ObscuredSurrogatePair) {
   // 'MUSICAL SYMBOL G CLEF': represented in UTF-16 as two characters
   // forming the surrogate pair 0x0001D11E.
-  Label label;
   base::string16 test_text = base::UTF8ToUTF16("\xF0\x9D\x84\x9E");
-  label.SetText(test_text);
-  label.SetObscured(true);
-  label.SizeToPreferredSize();
+  label()->SetText(test_text);
+  label()->SetObscured(true);
+  label()->SizeToPreferredSize();
   EXPECT_EQ(base::string16(1, gfx::RenderText::kPasswordReplacementChar),
-            label.GetDisplayTextForTesting());
-  EXPECT_EQ(test_text, label.text());
+            label()->GetDisplayTextForTesting());
+  EXPECT_EQ(test_text, label()->text());
 }
 
 // This test case verifies the label preferred size will change based on the
@@ -238,205 +299,197 @@ TEST_F(LabelTest, ObscuredSurrogatePair) {
 // TODO(mukai): fix the code assuming this behavior and then fix Label
 // implementation, and remove this test case.
 TEST_F(LabelTest, MultilinePreferredSizeTest) {
-  Label label;
-  label.SetText(ASCIIToUTF16("This is an example."));
+  label()->SetText(ASCIIToUTF16("This is an example."));
 
-  gfx::Size single_line_size = label.GetPreferredSize();
+  gfx::Size single_line_size = label()->GetPreferredSize();
 
-  label.SetMultiLine(true);
-  gfx::Size multi_line_size = label.GetPreferredSize();
+  label()->SetMultiLine(true);
+  gfx::Size multi_line_size = label()->GetPreferredSize();
   EXPECT_EQ(single_line_size, multi_line_size);
 
   int new_width = multi_line_size.width() / 2;
-  label.SetBounds(0, 0, new_width, label.GetHeightForWidth(new_width));
-  gfx::Size new_size = label.GetPreferredSize();
+  label()->SetBounds(0, 0, new_width, label()->GetHeightForWidth(new_width));
+  gfx::Size new_size = label()->GetPreferredSize();
   EXPECT_GT(multi_line_size.width(), new_size.width());
   EXPECT_LT(multi_line_size.height(), new_size.height());
 }
 
 TEST_F(LabelTest, TooltipProperty) {
-  Label label;
-  label.SetText(ASCIIToUTF16("My cool string."));
+  label()->SetText(ASCIIToUTF16("My cool string."));
 
   // Initially, label has no bounds, its text does not fit, and therefore its
   // text should be returned as the tooltip text.
   base::string16 tooltip;
-  EXPECT_TRUE(label.GetTooltipText(gfx::Point(), &tooltip));
-  EXPECT_EQ(label.text(), tooltip);
+  EXPECT_TRUE(label()->GetTooltipText(gfx::Point(), &tooltip));
+  EXPECT_EQ(label()->text(), tooltip);
 
   // While tooltip handling is disabled, GetTooltipText() should fail.
-  label.SetHandlesTooltips(false);
-  EXPECT_FALSE(label.GetTooltipText(gfx::Point(), &tooltip));
-  label.SetHandlesTooltips(true);
+  label()->SetHandlesTooltips(false);
+  EXPECT_FALSE(label()->GetTooltipText(gfx::Point(), &tooltip));
+  label()->SetHandlesTooltips(true);
 
   // When set, custom tooltip text should be returned instead of the label's
   // text.
   base::string16 tooltip_text(ASCIIToUTF16("The tooltip!"));
-  label.SetTooltipText(tooltip_text);
-  EXPECT_TRUE(label.GetTooltipText(gfx::Point(), &tooltip));
+  label()->SetTooltipText(tooltip_text);
+  EXPECT_TRUE(label()->GetTooltipText(gfx::Point(), &tooltip));
   EXPECT_EQ(tooltip_text, tooltip);
 
   // While tooltip handling is disabled, GetTooltipText() should fail.
-  label.SetHandlesTooltips(false);
-  EXPECT_FALSE(label.GetTooltipText(gfx::Point(), &tooltip));
-  label.SetHandlesTooltips(true);
+  label()->SetHandlesTooltips(false);
+  EXPECT_FALSE(label()->GetTooltipText(gfx::Point(), &tooltip));
+  label()->SetHandlesTooltips(true);
 
   // When the tooltip text is set to an empty string, the original behavior is
   // restored.
-  label.SetTooltipText(base::string16());
-  EXPECT_TRUE(label.GetTooltipText(gfx::Point(), &tooltip));
-  EXPECT_EQ(label.text(), tooltip);
+  label()->SetTooltipText(base::string16());
+  EXPECT_TRUE(label()->GetTooltipText(gfx::Point(), &tooltip));
+  EXPECT_EQ(label()->text(), tooltip);
 
   // While tooltip handling is disabled, GetTooltipText() should fail.
-  label.SetHandlesTooltips(false);
-  EXPECT_FALSE(label.GetTooltipText(gfx::Point(), &tooltip));
-  label.SetHandlesTooltips(true);
+  label()->SetHandlesTooltips(false);
+  EXPECT_FALSE(label()->GetTooltipText(gfx::Point(), &tooltip));
+  label()->SetHandlesTooltips(true);
 
   // Make the label big enough to hold the text
   // and expect there to be no tooltip.
-  label.SetBounds(0, 0, 1000, 40);
-  EXPECT_FALSE(label.GetTooltipText(gfx::Point(), &tooltip));
+  label()->SetBounds(0, 0, 1000, 40);
+  EXPECT_FALSE(label()->GetTooltipText(gfx::Point(), &tooltip));
 
   // Shrinking the single-line label's height shouldn't trigger a tooltip.
-  label.SetBounds(0, 0, 1000, label.GetPreferredSize().height() / 2);
-  EXPECT_FALSE(label.GetTooltipText(gfx::Point(), &tooltip));
+  label()->SetBounds(0, 0, 1000, label()->GetPreferredSize().height() / 2);
+  EXPECT_FALSE(label()->GetTooltipText(gfx::Point(), &tooltip));
 
   // Verify that explicitly set tooltip text is shown, regardless of size.
-  label.SetTooltipText(tooltip_text);
-  EXPECT_TRUE(label.GetTooltipText(gfx::Point(), &tooltip));
+  label()->SetTooltipText(tooltip_text);
+  EXPECT_TRUE(label()->GetTooltipText(gfx::Point(), &tooltip));
   EXPECT_EQ(tooltip_text, tooltip);
   // Clear out the explicitly set tooltip text.
-  label.SetTooltipText(base::string16());
+  label()->SetTooltipText(base::string16());
 
   // Shrink the bounds and the tooltip should come back.
-  label.SetBounds(0, 0, 10, 10);
-  EXPECT_TRUE(label.GetTooltipText(gfx::Point(), &tooltip));
+  label()->SetBounds(0, 0, 10, 10);
+  EXPECT_TRUE(label()->GetTooltipText(gfx::Point(), &tooltip));
 
   // Make the label obscured and there is no tooltip.
-  label.SetObscured(true);
-  EXPECT_FALSE(label.GetTooltipText(gfx::Point(), &tooltip));
+  label()->SetObscured(true);
+  EXPECT_FALSE(label()->GetTooltipText(gfx::Point(), &tooltip));
 
   // Obscuring the text shouldn't permanently clobber the tooltip.
-  label.SetObscured(false);
-  EXPECT_TRUE(label.GetTooltipText(gfx::Point(), &tooltip));
+  label()->SetObscured(false);
+  EXPECT_TRUE(label()->GetTooltipText(gfx::Point(), &tooltip));
 
   // Making the label multiline shouldn't eliminate the tooltip.
-  label.SetMultiLine(true);
-  EXPECT_TRUE(label.GetTooltipText(gfx::Point(), &tooltip));
+  label()->SetMultiLine(true);
+  EXPECT_TRUE(label()->GetTooltipText(gfx::Point(), &tooltip));
   // Expanding the multiline label bounds should eliminate the tooltip.
-  label.SetBounds(0, 0, 1000, 1000);
-  EXPECT_FALSE(label.GetTooltipText(gfx::Point(), &tooltip));
+  label()->SetBounds(0, 0, 1000, 1000);
+  EXPECT_FALSE(label()->GetTooltipText(gfx::Point(), &tooltip));
 
   // Verify that setting the tooltip still shows it.
-  label.SetTooltipText(tooltip_text);
-  EXPECT_TRUE(label.GetTooltipText(gfx::Point(), &tooltip));
+  label()->SetTooltipText(tooltip_text);
+  EXPECT_TRUE(label()->GetTooltipText(gfx::Point(), &tooltip));
   EXPECT_EQ(tooltip_text, tooltip);
   // Clear out the tooltip.
-  label.SetTooltipText(base::string16());
+  label()->SetTooltipText(base::string16());
 }
 
 TEST_F(LabelTest, Accessibility) {
-  Label label;
-  label.SetText(ASCIIToUTF16("My special text."));
+  label()->SetText(ASCIIToUTF16("My special text."));
 
   ui::AXViewState state;
-  label.GetAccessibleState(&state);
+  label()->GetAccessibleState(&state);
   EXPECT_EQ(ui::AX_ROLE_STATIC_TEXT, state.role);
-  EXPECT_EQ(label.text(), state.name);
+  EXPECT_EQ(label()->text(), state.name);
   EXPECT_TRUE(state.HasStateFlag(ui::AX_STATE_READ_ONLY));
 }
 
 TEST_F(LabelTest, TextChangeWithoutLayout) {
-  Label label;
-  label.SetText(ASCIIToUTF16("Example"));
-  label.SetBounds(0, 0, 200, 200);
+  label()->SetText(ASCIIToUTF16("Example"));
+  label()->SetBounds(0, 0, 200, 200);
 
   gfx::Canvas canvas(gfx::Size(200, 200), 1.0f, true);
-  label.Paint(ui::CanvasPainter(&canvas, 1.f).context());
-  EXPECT_EQ(1u, label.lines_.size());
-  EXPECT_EQ(ASCIIToUTF16("Example"), label.lines_[0]->GetDisplayText());
+  label()->OnPaint(&canvas);
+  EXPECT_EQ(1u, label()->lines_.size());
+  EXPECT_EQ(ASCIIToUTF16("Example"), label()->lines_[0]->GetDisplayText());
 
-  label.SetText(ASCIIToUTF16("Altered"));
+  label()->SetText(ASCIIToUTF16("Altered"));
   // The altered text should be painted even though Layout() or SetBounds() are
   // not called.
-  label.Paint(ui::CanvasPainter(&canvas, 1.f).context());
-  EXPECT_EQ(1u, label.lines_.size());
-  EXPECT_EQ(ASCIIToUTF16("Altered"), label.lines_[0]->GetDisplayText());
+  label()->OnPaint(&canvas);
+  EXPECT_EQ(1u, label()->lines_.size());
+  EXPECT_EQ(ASCIIToUTF16("Altered"), label()->lines_[0]->GetDisplayText());
 }
 
 TEST_F(LabelTest, EmptyLabelSizing) {
-  Label label;
-  const gfx::Size expected_size(0, label.font_list().GetHeight());
-  EXPECT_EQ(expected_size, label.GetPreferredSize());
-  label.SetMultiLine(!label.multi_line());
-  EXPECT_EQ(expected_size, label.GetPreferredSize());
+  const gfx::Size expected_size(0, label()->font_list().GetHeight());
+  EXPECT_EQ(expected_size, label()->GetPreferredSize());
+  label()->SetMultiLine(!label()->multi_line());
+  EXPECT_EQ(expected_size, label()->GetPreferredSize());
 }
 
 TEST_F(LabelTest, SingleLineSizing) {
-  Label label;
-  label.SetText(ASCIIToUTF16("A not so random string in one line."));
-  const gfx::Size size = label.GetPreferredSize();
+  label()->SetText(ASCIIToUTF16("A not so random string in one line."));
+  const gfx::Size size = label()->GetPreferredSize();
   EXPECT_GT(size.height(), kMinTextDimension);
   EXPECT_GT(size.width(), kMinTextDimension);
 
   // Setting a size smaller than preferred should not change the preferred size.
-  label.SetSize(gfx::Size(size.width() / 2, size.height() / 2));
-  EXPECT_EQ(size, label.GetPreferredSize());
+  label()->SetSize(gfx::Size(size.width() / 2, size.height() / 2));
+  EXPECT_EQ(size, label()->GetPreferredSize());
 
   const gfx::Insets border(10, 20, 30, 40);
-  label.SetBorder(Border::CreateEmptyBorder(
+  label()->SetBorder(Border::CreateEmptyBorder(
       border.top(), border.left(), border.bottom(), border.right()));
-  const gfx::Size size_with_border = label.GetPreferredSize();
+  const gfx::Size size_with_border = label()->GetPreferredSize();
   EXPECT_EQ(size_with_border.height(), size.height() + border.height());
   EXPECT_EQ(size_with_border.width(), size.width() + border.width());
   EXPECT_EQ(size.height() + border.height(),
-            label.GetHeightForWidth(size_with_border.width()));
+            label()->GetHeightForWidth(size_with_border.width()));
 }
 
 TEST_F(LabelTest, MultilineSmallAvailableWidthSizing) {
-  Label label;
-  label.SetMultiLine(true);
-  label.SetAllowCharacterBreak(true);
-  label.SetText(ASCIIToUTF16("Too Wide."));
+  label()->SetMultiLine(true);
+  label()->SetAllowCharacterBreak(true);
+  label()->SetText(ASCIIToUTF16("Too Wide."));
 
   // Check that Label can be laid out at a variety of small sizes,
   // splitting the words into up to one character per line if necessary.
   // Incorrect word splitting may cause infinite loops in text layout.
-  gfx::Size required_size = label.GetPreferredSize();
+  gfx::Size required_size = label()->GetPreferredSize();
   for (int i = 1; i < required_size.width(); ++i)
-    EXPECT_GT(label.GetHeightForWidth(i), 0);
+    EXPECT_GT(label()->GetHeightForWidth(i), 0);
 }
 
 // Verifies if SetAllowCharacterBreak(true) doesn't change the preferred size.
 // See crbug.com/469559
 TEST_F(LabelTest, PreferredSizeForAllowCharacterBreak) {
-  Label label(base::ASCIIToUTF16("Example"));
-  gfx::Size preferred_size = label.GetPreferredSize();
+  label()->SetText(base::ASCIIToUTF16("Example"));
+  gfx::Size preferred_size = label()->GetPreferredSize();
 
-  label.SetMultiLine(true);
-  label.SetAllowCharacterBreak(true);
-  EXPECT_EQ(preferred_size, label.GetPreferredSize());
+  label()->SetMultiLine(true);
+  label()->SetAllowCharacterBreak(true);
+  EXPECT_EQ(preferred_size, label()->GetPreferredSize());
 }
 
 TEST_F(LabelTest, MultiLineSizing) {
-  Label label;
-  label.SetText(
+  label()->SetText(
       ASCIIToUTF16("A random string\nwith multiple lines\nand returns!"));
-  label.SetMultiLine(true);
+  label()->SetMultiLine(true);
 
   // GetPreferredSize
-  gfx::Size required_size = label.GetPreferredSize();
+  gfx::Size required_size = label()->GetPreferredSize();
   EXPECT_GT(required_size.height(), kMinTextDimension);
   EXPECT_GT(required_size.width(), kMinTextDimension);
 
   // SizeToFit with unlimited width.
-  label.SizeToFit(0);
-  int required_width = label.GetLocalBounds().width();
+  label()->SizeToFit(0);
+  int required_width = label()->GetLocalBounds().width();
   EXPECT_GT(required_width, kMinTextDimension);
 
   // SizeToFit with limited width.
-  label.SizeToFit(required_width - 1);
-  int constrained_width = label.GetLocalBounds().width();
+  label()->SizeToFit(required_width - 1);
+  int constrained_width = label()->GetLocalBounds().width();
 #if defined(OS_WIN)
   // Canvas::SizeStringInt (in ui/gfx/canvas_linux.cc)
   // has to be fixed to return the size that fits to given width/height.
@@ -445,13 +498,14 @@ TEST_F(LabelTest, MultiLineSizing) {
   EXPECT_GT(constrained_width, kMinTextDimension);
 
   // Change the width back to the desire width.
-  label.SizeToFit(required_width);
-  EXPECT_EQ(required_width, label.GetLocalBounds().width());
+  label()->SizeToFit(required_width);
+  EXPECT_EQ(required_width, label()->GetLocalBounds().width());
 
   // General tests for GetHeightForWidth.
-  int required_height = label.GetHeightForWidth(required_width);
+  int required_height = label()->GetHeightForWidth(required_width);
   EXPECT_GT(required_height, kMinTextDimension);
-  int height_for_constrained_width = label.GetHeightForWidth(constrained_width);
+  int height_for_constrained_width =
+      label()->GetHeightForWidth(constrained_width);
 #if defined(OS_WIN)
   // Canvas::SizeStringInt (in ui/gfx/canvas_linux.cc)
   // has to be fixed to return the size that fits to given width/height.
@@ -461,27 +515,27 @@ TEST_F(LabelTest, MultiLineSizing) {
   // same result for the height because the constrainted width is the tight
   // width when given "required_width - 1" as the max width.
   EXPECT_EQ(height_for_constrained_width,
-            label.GetHeightForWidth(required_width - 1));
+            label()->GetHeightForWidth(required_width - 1));
 
   // Test everything with borders.
   gfx::Insets border(10, 20, 30, 40);
-  label.SetBorder(Border::CreateEmptyBorder(
+  label()->SetBorder(Border::CreateEmptyBorder(
       border.top(), border.left(), border.bottom(), border.right()));
 
   // SizeToFit and borders.
-  label.SizeToFit(0);
-  int required_width_with_border = label.GetLocalBounds().width();
+  label()->SizeToFit(0);
+  int required_width_with_border = label()->GetLocalBounds().width();
   EXPECT_EQ(required_width_with_border, required_width + border.width());
 
   // GetHeightForWidth and borders.
   int required_height_with_border =
-      label.GetHeightForWidth(required_width_with_border);
+      label()->GetHeightForWidth(required_width_with_border);
   EXPECT_EQ(required_height_with_border, required_height + border.height());
 
   // Test that the border width is subtracted before doing the height
   // calculation.  If it is, then the height will grow when width
   // is shrunk.
-  int height1 = label.GetHeightForWidth(required_width_with_border - 1);
+  int height1 = label()->GetHeightForWidth(required_width_with_border - 1);
 #if defined(OS_WIN)
   // Canvas::SizeStringInt (in ui/gfx/canvas_linux.cc)
   // has to be fixed to return the size that fits to given width/height.
@@ -490,8 +544,8 @@ TEST_F(LabelTest, MultiLineSizing) {
   EXPECT_EQ(height1, height_for_constrained_width + border.height());
 
   // GetPreferredSize and borders.
-  label.SetBounds(0, 0, 0, 0);
-  gfx::Size required_size_with_border = label.GetPreferredSize();
+  label()->SetBounds(0, 0, 0, 0);
+  gfx::Size required_size_with_border = label()->GetPreferredSize();
   EXPECT_EQ(required_size_with_border.height(),
             required_size.height() + border.height());
   EXPECT_EQ(required_size_with_border.width(),
@@ -503,132 +557,118 @@ TEST_F(LabelTest, MultiLineSizing) {
 TEST_F(LabelTest, MultiLineSizingWithElide) {
   const base::string16 text =
       ASCIIToUTF16("A random string\nwith multiple lines\nand returns!");
-  Label label;
-  label.SetText(text);
-  label.SetMultiLine(true);
+  label()->SetText(text);
+  label()->SetMultiLine(true);
 
-  gfx::Size required_size = label.GetPreferredSize();
+  gfx::Size required_size = label()->GetPreferredSize();
   EXPECT_GT(required_size.height(), kMinTextDimension);
   EXPECT_GT(required_size.width(), kMinTextDimension);
-  label.SetBoundsRect(gfx::Rect(required_size));
+  label()->SetBoundsRect(gfx::Rect(required_size));
 
-  label.SetElideBehavior(gfx::ELIDE_TAIL);
-  EXPECT_EQ(required_size.ToString(), label.GetPreferredSize().ToString());
-  EXPECT_EQ(text, label.GetDisplayTextForTesting());
+  label()->SetElideBehavior(gfx::ELIDE_TAIL);
+  EXPECT_EQ(required_size.ToString(), label()->GetPreferredSize().ToString());
+  EXPECT_EQ(text, label()->GetDisplayTextForTesting());
 
-  label.SizeToFit(required_size.width() - 1);
-  gfx::Size narrow_size = label.GetPreferredSize();
+  label()->SizeToFit(required_size.width() - 1);
+  gfx::Size narrow_size = label()->GetPreferredSize();
   EXPECT_GT(required_size.width(), narrow_size.width());
   EXPECT_LT(required_size.height(), narrow_size.height());
 
   // SetBounds() doesn't change the preferred size.
-  label.SetBounds(0, 0, narrow_size.width() - 1, narrow_size.height());
-  EXPECT_EQ(narrow_size.ToString(), label.GetPreferredSize().ToString());
+  label()->SetBounds(0, 0, narrow_size.width() - 1, narrow_size.height());
+  EXPECT_EQ(narrow_size.ToString(), label()->GetPreferredSize().ToString());
 
   // Paint() doesn't change the preferred size.
   gfx::Canvas canvas;
-  label.Paint(ui::CanvasPainter(&canvas, 1.f).context());
-  EXPECT_EQ(narrow_size.ToString(), label.GetPreferredSize().ToString());
+  label()->OnPaint(&canvas);
+  EXPECT_EQ(narrow_size.ToString(), label()->GetPreferredSize().ToString());
 }
 
 // Check that labels support GetTooltipHandlerForPoint.
 TEST_F(LabelTest, GetTooltipHandlerForPoint) {
-  // A root view must be defined for this test because the hit-testing
-  // behaviour used by GetTooltipHandlerForPoint() is defined by
-  // the ViewTargeter installed on the root view.
-  Widget widget;
-  Widget::InitParams init_params =
-      CreateParams(Widget::InitParams::TYPE_POPUP);
-  init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
-  init_params.bounds = gfx::Rect(0, 0, 200, 200);
-  widget.Init(init_params);
-
-  Label label;
-  label.SetText(
+  label()->SetText(
       ASCIIToUTF16("A string that's long enough to exceed the bounds"));
-  label.SetBounds(0, 0, 10, 10);
-  widget.SetContentsView(&label);
+  label()->SetBounds(0, 0, 10, 10);
 
   // By default, labels start out as tooltip handlers.
-  ASSERT_TRUE(label.handles_tooltips());
+  ASSERT_TRUE(label()->handles_tooltips());
 
   // There's a default tooltip if the text is too big to fit.
-  EXPECT_EQ(&label, label.GetTooltipHandlerForPoint(gfx::Point(2, 2)));
+  EXPECT_EQ(label(), label()->GetTooltipHandlerForPoint(gfx::Point(2, 2)));
 
   // If tooltip handling is disabled, the label should not provide a tooltip
   // handler.
-  label.SetHandlesTooltips(false);
-  EXPECT_FALSE(label.GetTooltipHandlerForPoint(gfx::Point(2, 2)));
-  label.SetHandlesTooltips(true);
+  label()->SetHandlesTooltips(false);
+  EXPECT_FALSE(label()->GetTooltipHandlerForPoint(gfx::Point(2, 2)));
+  label()->SetHandlesTooltips(true);
 
   // If there's no default tooltip, this should return NULL.
-  label.SetBounds(0, 0, 500, 50);
-  EXPECT_FALSE(label.GetTooltipHandlerForPoint(gfx::Point(2, 2)));
+  label()->SetBounds(0, 0, 500, 50);
+  EXPECT_FALSE(label()->GetTooltipHandlerForPoint(gfx::Point(2, 2)));
 
-  label.SetTooltipText(ASCIIToUTF16("a tooltip"));
+  label()->SetTooltipText(ASCIIToUTF16("a tooltip"));
   // If the point hits the label, and tooltip is set, the label should be
   // returned as its tooltip handler.
-  EXPECT_EQ(&label, label.GetTooltipHandlerForPoint(gfx::Point(2, 2)));
+  EXPECT_EQ(label(), label()->GetTooltipHandlerForPoint(gfx::Point(2, 2)));
 
   // Additionally, GetTooltipHandlerForPoint should verify that the label
   // actually contains the point.
-  EXPECT_FALSE(label.GetTooltipHandlerForPoint(gfx::Point(2, 51)));
-  EXPECT_FALSE(label.GetTooltipHandlerForPoint(gfx::Point(-1, 20)));
+  EXPECT_FALSE(label()->GetTooltipHandlerForPoint(gfx::Point(2, 51)));
+  EXPECT_FALSE(label()->GetTooltipHandlerForPoint(gfx::Point(-1, 20)));
 
   // Again, if tooltip handling is disabled, the label should not provide a
   // tooltip handler.
-  label.SetHandlesTooltips(false);
-  EXPECT_FALSE(label.GetTooltipHandlerForPoint(gfx::Point(2, 2)));
-  EXPECT_FALSE(label.GetTooltipHandlerForPoint(gfx::Point(2, 51)));
-  EXPECT_FALSE(label.GetTooltipHandlerForPoint(gfx::Point(-1, 20)));
-  label.SetHandlesTooltips(true);
+  label()->SetHandlesTooltips(false);
+  EXPECT_FALSE(label()->GetTooltipHandlerForPoint(gfx::Point(2, 2)));
+  EXPECT_FALSE(label()->GetTooltipHandlerForPoint(gfx::Point(2, 51)));
+  EXPECT_FALSE(label()->GetTooltipHandlerForPoint(gfx::Point(-1, 20)));
+  label()->SetHandlesTooltips(true);
 
   // GetTooltipHandlerForPoint works should work in child bounds.
-  label.SetBounds(2, 2, 10, 10);
-  EXPECT_EQ(&label, label.GetTooltipHandlerForPoint(gfx::Point(1, 5)));
-  EXPECT_FALSE(label.GetTooltipHandlerForPoint(gfx::Point(3, 11)));
+  label()->SetBounds(2, 2, 10, 10);
+  EXPECT_EQ(label(), label()->GetTooltipHandlerForPoint(gfx::Point(1, 5)));
+  EXPECT_FALSE(label()->GetTooltipHandlerForPoint(gfx::Point(3, 11)));
 }
 
 // Check that label releases its internal layout data when it's unnecessary.
 TEST_F(LabelTest, ResetRenderTextData) {
-  Label label;
-  label.SetText(ASCIIToUTF16("Example"));
-  label.SizeToPreferredSize();
-  gfx::Size preferred_size = label.GetPreferredSize();
+  label()->SetText(ASCIIToUTF16("Example"));
+  label()->SizeToPreferredSize();
+  gfx::Size preferred_size = label()->GetPreferredSize();
 
   EXPECT_NE(gfx::Size().ToString(), preferred_size.ToString());
-  EXPECT_EQ(0u, label.lines_.size());
+  EXPECT_EQ(0u, label()->lines_.size());
 
   gfx::Canvas canvas(preferred_size, 1.0f, true);
-  label.Paint(ui::CanvasPainter(&canvas, 1.f).context());
-  EXPECT_EQ(1u, label.lines_.size());
+  label()->OnPaint(&canvas);
+  EXPECT_EQ(1u, label()->lines_.size());
 
   // Label should recreate its RenderText object when it's invisible, to release
   // the layout structures and data.
-  label.SetVisible(false);
-  EXPECT_EQ(0u, label.lines_.size());
+  label()->SetVisible(false);
+  EXPECT_EQ(0u, label()->lines_.size());
 
   // Querying fields or size information should not recompute the layout
   // unnecessarily.
-  EXPECT_EQ(ASCIIToUTF16("Example"), label.text());
-  EXPECT_EQ(0u, label.lines_.size());
+  EXPECT_EQ(ASCIIToUTF16("Example"), label()->text());
+  EXPECT_EQ(0u, label()->lines_.size());
 
-  EXPECT_EQ(preferred_size.ToString(), label.GetPreferredSize().ToString());
-  EXPECT_EQ(0u, label.lines_.size());
+  EXPECT_EQ(preferred_size.ToString(), label()->GetPreferredSize().ToString());
+  EXPECT_EQ(0u, label()->lines_.size());
 
   // RenderText data should be back when it's necessary.
-  label.SetVisible(true);
-  EXPECT_EQ(0u, label.lines_.size());
+  label()->SetVisible(true);
+  EXPECT_EQ(0u, label()->lines_.size());
 
-  label.Paint(ui::CanvasPainter(&canvas, 1.f).context());
-  EXPECT_EQ(1u, label.lines_.size());
+  label()->OnPaint(&canvas);
+  EXPECT_EQ(1u, label()->lines_.size());
 
   // Changing layout just resets |lines_|. It'll recover next time it's drawn.
-  label.SetBounds(0, 0, 10, 10);
-  EXPECT_EQ(0u, label.lines_.size());
+  label()->SetBounds(0, 0, 10, 10);
+  EXPECT_EQ(0u, label()->lines_.size());
 
-  label.Paint(ui::CanvasPainter(&canvas, 1.f).context());
-  EXPECT_EQ(1u, label.lines_.size());
+  label()->OnPaint(&canvas);
+  EXPECT_EQ(1u, label()->lines_.size());
 }
 
 #if !defined(OS_MACOSX)
@@ -637,16 +677,15 @@ TEST_F(LabelTest, MultilineSupportedRenderText) {
       gfx::RenderText::CreateInstance());
   ASSERT_TRUE(render_text->MultilineSupported());
 
-  Label label;
-  label.SetText(ASCIIToUTF16("Example of\nmultilined label"));
-  label.SetMultiLine(true);
-  label.SizeToPreferredSize();
+  label()->SetText(ASCIIToUTF16("Example of\nmultilined label"));
+  label()->SetMultiLine(true);
+  label()->SizeToPreferredSize();
 
-  gfx::Canvas canvas(label.GetPreferredSize(), 1.0f, true);
-  label.Paint(ui::CanvasPainter(&canvas, 1.f).context());
+  gfx::Canvas canvas(label()->GetPreferredSize(), 1.0f, true);
+  label()->OnPaint(&canvas);
 
   // There's only one 'line', RenderText itself supports multiple lines.
-  EXPECT_EQ(1u, label.lines_.size());
+  EXPECT_EQ(1u, label()->lines_.size());
 }
 #endif
 
@@ -680,7 +719,7 @@ TEST_F(LabelTest, NoSchedulePaintInOnPaint) {
   EXPECT_EQ(count, label.schedule_paint_count());  // Unchanged.
 }
 
-TEST_F(LabelFocusTest, FocusBounds) {
+TEST_F(LabelTest, FocusBounds) {
   label()->SetText(ASCIIToUTF16("Example"));
   gfx::Size normal_size = label()->GetPreferredSize();
 
@@ -720,7 +759,7 @@ TEST_F(LabelFocusTest, FocusBounds) {
   EXPECT_EQ(focusable_size.width() / 2, focus_bounds.width());
 }
 
-TEST_F(LabelFocusTest, EmptyLabel) {
+TEST_F(LabelTest, EmptyLabel) {
   label()->SetFocusBehavior(View::FocusBehavior::ALWAYS);
   label()->RequestFocus();
   label()->SizeToPreferredSize();
@@ -730,4 +769,154 @@ TEST_F(LabelFocusTest, EmptyLabel) {
   EXPECT_LT(label()->font_list().GetHeight(), focus_bounds.height());
 }
 
+// Disabled on Mac since it uses RenderTextMac, which does not support text
+// selection.
+// Todo(karandeepb): Re-enable these once Mac uses RenderTextHarfBuzz for

[msw, 2016/11/01 23:42:22]

ditto nit: TODO

[karandeepb, 2016/11/02 06:29:38]

Done.

+// Labels. Tracked in https://crbug.com/630365.

[msw, 2016/11/01 23:42:22]

aside: careful overloading a single issue with many defects; sometimes it makes
more sense to file separate issues for different aspects of some larger
meta-task. Really, it'd be a shame to mark 630365 fixed once it works on
win/linux/cros, and let this dangle with a reference to a closed bug while
there's no ongoing work or tracking bug to support mac.

In this sepcific case, maybe we should cite 454835?

[karandeepb, 2016/11/02 06:29:38]

Yeah you are correct. Have filed a new issue blocking the larger Label selection
issue.

+#if !defined(OS_MACOSX)
+TEST_F(LabelTest, Selectable) {
+  // By default labels don't support text selection.

[msw, 2016/11/01 23:42:22]

grammar nit: add a comma after "By default" (matches your use below).

[karandeepb, 2016/11/02 06:29:38]

Done.

+  EXPECT_FALSE(label()->selectable());
+
+  EXPECT_TRUE(label()->SetSelectable(true));
+  EXPECT_TRUE(label()->selectable());
+
+  // Verify making a label multiline, causes the label to not support text

[msw, 2016/11/01 23:42:22]

grammar nit: remove the comma and optionally say "Verify that"

[karandeepb, 2016/11/02 06:29:38]

Done.

+  // selection.
+  label()->SetMultiLine(true);
+  EXPECT_FALSE(label()->selectable());
+}
+
+// Verify labels supporting text selection, get focus on clicks.

[msw, 2016/11/01 23:42:22]

ditto grammar nit: remove the comma and optionally say "Verify that"

[karandeepb, 2016/11/02 06:29:38]

Done.

+TEST_F(LabelTest, FocusOnClick) {
+  label()->SetText(ASCIIToUTF16("text"));
+  label()->SizeToPreferredSize();
+
+  // By default, labels don't get focus on click.
+  PerformClick(gfx::Point());
+  EXPECT_NE(label(), GetFocusedView());

[msw, 2016/11/01 23:42:22]

Be careful checking focus in a unit test; multiple unit tests running in
parallel can cause conflicts with global state like focus. These might need to
be made into interactive_ui_tests, but I'm not 100% sure that's necessary...
sadrul or sky might know offhand. If you do need to make interactive_ui_tests;
consider reverting the LabelTest changes here.

[karandeepb, 2016/11/02 06:29:37]

There are similar unit tests at many other places. I think there are already
checks in place to ensure key window state can be "faked" in unit tests. For
example on Mac, we have this -
https://cs.chromium.org/chromium/src/ui/base/test/scoped_fake_nswindow_focus.....
Not really sure how other platforms handle this though.

+
+  EXPECT_TRUE(label()->SetSelectable(true));
+  PerformClick(gfx::Point());
+  EXPECT_EQ(label(), GetFocusedView());
+}
+
+// Verify labels supporting text selection do not get focus on tab traversal by
+// default.
+TEST_F(LabelTest, FocusTraversal) {
+  // Add another view before |label()|.
+  View* view = new View();
+  view->SetFocusBehavior(View::FocusBehavior::ALWAYS);
+  widget()->GetContentsView()->AddChildViewAt(view, 0);
+
+  // By default, labels are not focusable.
+  view->RequestFocus();
+  EXPECT_EQ(view, GetFocusedView());
+  widget()->GetFocusManager()->AdvanceFocus(false);
+  EXPECT_NE(label(), GetFocusedView());
+
+  // On enabling text selection, labels can get focus on clicks but not via tab
+  // traversal.
+  view->RequestFocus();
+  EXPECT_EQ(view, GetFocusedView());
+  EXPECT_TRUE(label()->SetSelectable(true));
+  widget()->GetFocusManager()->AdvanceFocus(false);
+  EXPECT_NE(label(), GetFocusedView());
+
+  // A label with FocusBehavior::ALWAYS should get focus via tab traversal.
+  view->RequestFocus();
+  EXPECT_EQ(view, GetFocusedView());
+  EXPECT_TRUE(label()->SetSelectable(false));
+  label()->SetFocusBehavior(View::FocusBehavior::ALWAYS);
+  widget()->GetFocusManager()->AdvanceFocus(false);
+  EXPECT_EQ(label(), GetFocusedView());
+}
+
+// Verify label text selection behavior on double and triple clicks.
+TEST_F(LabelTest, DoubleTripleClick) {
+  label()->SetText(ASCIIToUTF16("Label double click"));
+  label()->SizeToPreferredSize();
+  EXPECT_TRUE(label()->SetSelectable(true));
+
+  PerformClick(gfx::Point());
+  EXPECT_TRUE(label()->GetSelectedText().empty());
+
+  // Double clicking should select the word under cursor.
+  PerformClick(gfx::Point(), ui::EF_IS_DOUBLE_CLICK);
+  EXPECT_STR_EQ("Label", label()->GetSelectedText());
+
+  // Triple clicking should select all the text.
+  PerformClick(gfx::Point());
+  EXPECT_EQ(label()->text(), label()->GetSelectedText());
+
+  // Clicking again should alternate to double click.
+  PerformClick(gfx::Point());
+  EXPECT_STR_EQ("Label", label()->GetSelectedText());
+
+  // Clicking at another location should clear the selection.
+  PerformClick(GetCursorPoint(8));
+  EXPECT_TRUE(label()->GetSelectedText().empty());
+  PerformClick(GetCursorPoint(8), ui::EF_IS_DOUBLE_CLICK);
+  EXPECT_STR_EQ("double", label()->GetSelectedText());
+}
+
+// Verify label text selection behavior on mouse drag.
+TEST_F(LabelTest, MouseDrag) {
+  label()->SetText(ASCIIToUTF16("Label mouse drag"));
+  label()->SizeToPreferredSize();
+  EXPECT_TRUE(label()->SetSelectable(true));
+
+  PerformClick(GetCursorPoint(5));
+  DragMouseTo(gfx::Point());

[msw, 2016/11/01 23:42:22]

It seems odd to send a drag event after release (part of click).
Should we do mouse press, drag, *then* release here and elsewhere below?

[karandeepb, 2016/11/02 06:29:38]

Yeah you are correct. Done.

+  EXPECT_STR_EQ("Label", label()->GetSelectedText());
+
+  DragMouseTo(GetCursorPoint(8));
+  EXPECT_STR_EQ(" mo", label()->GetSelectedText());
+
+  DragMouseTo(gfx::Point(200, 0));
+  EXPECT_STR_EQ(" mouse drag", label()->GetSelectedText());
+}
+
+// Verify the initially selected word on a double click, remains selected on
+// mouse dragging.
+TEST_F(LabelTest, MouseDragWord) {
+  label()->SetText(ASCIIToUTF16("Label drag word"));
+  label()->SizeToPreferredSize();
+  EXPECT_TRUE(label()->SetSelectable(true));
+
+  PerformClick(GetCursorPoint(8));
+  PerformClick(GetCursorPoint(8), ui::EF_IS_DOUBLE_CLICK);
+  EXPECT_STR_EQ("drag", label()->GetSelectedText());
+
+  DragMouseTo(gfx::Point());
+  EXPECT_STR_EQ("Label drag", label()->GetSelectedText());
+
+  DragMouseTo(gfx::Point(200, 0));
+  EXPECT_STR_EQ("drag word", label()->GetSelectedText());
+}
+#endif  // OS_MACOSX
+
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
+// Verify selection clipboard behavior on text selection. Disabled due to
+// http://crbug.com/396477.
+TEST_F(LabelTest, DISABLED_SelectionClipboard) {
+  label()->SetText(ASCIIToUTF16("Label selection clipboard"));
+  label()->SizeToPreferredSize();
+  EXPECT_TRUE(label()->SetSelectable(true));
+
+  // Verify programmatic modification of selection, does not modify the
+  // selection clipboard.
+  label()->SelectRange(gfx::Range(2, 5));
+  EXPECT_STR_EQ("bel", label()->GetSelectedText());
+  EXPECT_TRUE(GetSelectionClipboardText().empty());
+
+  // Verify text selection using the mouse, updates the selection clipboard.

[msw, 2016/11/01 23:42:22]

grammar nit: remove comma

[karandeepb, 2016/11/02 06:29:38]

Done.

+  PerformClick(GetCursorPoint(5));
+  DragMouseTo(gfx::Point());
+  PerformMouseRelease(gfx::Point());
+  EXPECT_STR_EQ("Label", label()->GetSelectedText());
+  EXPECT_STR_EQ("Label", GetSelectionClipboardText());
+}
+#endif
+
 }  // namespace views