Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2413203004: [heap] Cancel tasks before tearing down the heap. (Closed)

Created:
4 years, 2 months ago by ulan
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Cancel tasks before tearing down the heap. BUG=chromium:654343 Committed: https://crrev.com/9365463d6f1fc11b2369fff63ca0ac825c61eae4 Cr-Commit-Position: refs/heads/master@{#40272}

Patch Set 1 #

Patch Set 2 : cancel new tasks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M src/cancelable-task.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/cancelable-task.cc View 1 2 chunks +9 lines, -2 lines 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
ptal
4 years, 2 months ago (2016-10-13 11:57:57 UTC) #2
Michael Lippautz
lgtm lgtm
4 years, 2 months ago (2016-10-13 13:32:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413203004/20001
4 years, 2 months ago (2016-10-13 13:35:09 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 14:35:11 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9365463d6f1fc11b2369fff63ca0ac825c61eae4 Cr-Commit-Position: refs/heads/master@{#40272}
4 years, 2 months ago (2016-10-13 14:35:22 UTC) #8
ulan
4 years, 2 months ago (2016-10-13 16:16:14 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2414073002/ by ulan@chromium.org.

The reason for reverting is: Timeout on gc stress bot..

Powered by Google App Engine
This is Rietveld 408576698