Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2413153004: mjsunit: Fix the error message produced by assertInstanceof. (Closed)

Created:
4 years, 2 months ago by marja
Modified:
4 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

mjsunit: Fix the error message produced by assertInstanceof. Used to be: Failure: expected <foo> is not an instance of <Bar> but of < Baz>> found <undefined> Should be: Failure: <foo> is not an instance of <Bar> but of <Baz> BUG= Committed: https://crrev.com/2a480eff395756f36eb0ae2fc0a573454b394268 Cr-Commit-Position: refs/heads/master@{#40319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M test/mjsunit/mjsunit.js View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
marja
ptal
4 years, 2 months ago (2016-10-14 13:31:03 UTC) #2
Toon Verwaest
lgtm
4 years, 2 months ago (2016-10-14 13:36:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413153004/1
4 years, 2 months ago (2016-10-14 13:40:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 14:12:03 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2a480eff395756f36eb0ae2fc0a573454b394268 Cr-Commit-Position: refs/heads/master@{#40319}
4 years, 2 months ago (2016-10-14 14:12:11 UTC) #8
marja
4 years, 2 months ago (2016-10-15 06:33:32 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2421033003/ by marja@chromium.org.

The reason for reverting is: This is probably not working for falsey values. I
cannot JavaScript :P.

Powered by Google App Engine
This is Rietveld 408576698