Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 2413113004: Fix wrong initialization of is_loaded in LibraryPrefix. (Closed)

Created:
4 years, 2 months ago by Florian Schneider
Modified:
4 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix wrong initialization of is_loaded in LibraryPrefix. My previous CL did not check if the prefix is deferred or not when deserializing it from the snapshot. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/2022348b111c24ae3382d80a80923958aa0d7461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M runtime/vm/clustered_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 2 months ago (2016-10-13 20:49:10 UTC) #2
rmacnak
lgtm
4 years, 2 months ago (2016-10-13 20:49:38 UTC) #3
Florian Schneider
4 years, 2 months ago (2016-10-13 20:51:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2022348b111c24ae3382d80a80923958aa0d7461 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698