Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Unified Diff: chrome/browser/ui/webui/help/help_utils_chromeos.cc

Issue 2413113003: Enable auto update over cellular when roaming is on by default
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/help/help_utils_chromeos.cc
diff --git a/chrome/browser/ui/webui/help/help_utils_chromeos.cc b/chrome/browser/ui/webui/help/help_utils_chromeos.cc
index d370f936df302572958a5bc204edef742af6df69..a211f5a39da93fe84c95e1130bece17f9e3723b4 100644
--- a/chrome/browser/ui/webui/help/help_utils_chromeos.cc
+++ b/chrome/browser/ui/webui/help/help_utils_chromeos.cc
@@ -8,10 +8,12 @@
#include <algorithm>
+#include "base/command_line.h"
#include "base/logging.h"
#include "base/values.h"
#include "chrome/browser/chromeos/settings/cros_settings.h"
#include "chrome/grit/generated_resources.h"
+#include "chromeos/chromeos_switches.h"
#include "chromeos/network/network_type_pattern.h"
#include "chromeos/settings/cros_settings_names.h"
#include "third_party/cros_system_api/dbus/service_constants.h"
@@ -26,6 +28,12 @@ const bool kDefaultUpdateOverCellularAllowed = false;
namespace help_utils_chromeos {
bool IsUpdateOverCellularAllowed() {
+ // Devices with a hard-coded policy to allow cellular roaming implicitly also
+ // allow updates over cellular; see http://crbug.com/640721.
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+ chromeos::switches::kAllowDataRoamingByDefault))
+ return true;
+
chromeos::CrosSettings* settings = chromeos::CrosSettings::Get();
if (!settings)
return kDefaultUpdateOverCellularAllowed;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698