Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2413113002: Hide the PopupTouchHandlerDrawable if it is occluded. (Closed)

Created:
4 years, 2 months ago by hush (inactive)
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Hide the PopupTouchHandlerDrawable if it is occluded. This CL follows Android Editor's logic to determine if the touch handler is visible by going up the view hierarchy. If the touch handler is fully occluded by any of its parent views, then it is considered not visible. In this way, the touch handlers won't appear overlapped with the IME window, if the app adjusts the window size based on IME window. BUG=639169 Review-Url: https://codereview.chromium.org/2410223003 Cr-Commit-Position: refs/heads/master@{#424896} (cherry picked from commit 4a64446000115cca6deba65288de86741a40062e) Committed: https://chromium.googlesource.com/chromium/src/+/afe45453fc54d87bbec43ce683358d43fbb44ef0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2 lines) Patch
M android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java View 3 chunks +50 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hush (inactive)
4 years, 2 months ago (2016-10-13 00:02:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
afe45453fc54d87bbec43ce683358d43fbb44ef0.

Powered by Google App Engine
This is Rietveld 408576698