Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2413093004: Generate the correct C++ symbol name for scoped native enums (Closed)

Created:
4 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 2 months ago
Reviewers:
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, xhwang, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate the correct C++ symbol name for scoped native enums BUG=655919 TBR=yzshen@chromium.org Committed: https://crrev.com/50ba000ec3132d4b12f55b1ff46e08407843e605 Cr-Commit-Position: refs/heads/master@{#425373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/tools/bindings/generators/cpp_templates/module-shared.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Ken Rockot(use gerrit already)
TBR yzshen since he's still OOO for a while and this is a trivial change.
4 years, 2 months ago (2016-10-14 15:44:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413093004/1
4 years, 2 months ago (2016-10-14 15:44:34 UTC) #7
xhwang
Thanks for the quick fix!
4 years, 2 months ago (2016-10-14 16:33:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 17:30:48 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 17:34:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50ba000ec3132d4b12f55b1ff46e08407843e605
Cr-Commit-Position: refs/heads/master@{#425373}

Powered by Google App Engine
This is Rietveld 408576698