Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Unified Diff: cc/blimp/layer_tree_host_remote.cc

Issue 2413063002: content/blimp: Set up hooks for enabling LTHRemote in the renderer. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/blimp/layer_tree_host_remote.cc
diff --git a/cc/blimp/layer_tree_host_remote.cc b/cc/blimp/layer_tree_host_remote.cc
index df457b79f99dc27c4ca39271efa4a06c7ebc65c3..56418c88418a2725a4e77caa8a73e0f68c70bffc 100644
--- a/cc/blimp/layer_tree_host_remote.cc
+++ b/cc/blimp/layer_tree_host_remote.cc
@@ -235,8 +235,9 @@ void LayerTreeHostRemote::DidStopFlinging() {
void LayerTreeHostRemote::SetDebugState(
const LayerTreeDebugState& debug_state) {
- // TODO(khushalsagar): Figure out if we need to send these to the client.
- NOTREACHED();
+ // If any debugging needs to be enabled, ideally it should be using the
+ // compositor on the client directly. But the setup code will always set this
+ // on initialization, even if the settings end up being a no-op.
Wez 2016/10/19 22:15:28 This comment is rather confusing. Are you simply
Khushal 2016/10/20 01:29:33 Yes, only the remoting end should need to have thi
}
const LayerTreeDebugState& LayerTreeHostRemote::GetDebugState() const {

Powered by Google App Engine
This is Rietveld 408576698