Issue 2413043002: views: call UpdateAfterChange() in Textfield::InsertOrReplaceText().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2413043002: views: call UpdateAfterChange() in Textfield::InsertOrReplaceText(). (Closed)

Created:
4 years, 2 months ago by Elly Fong-Jones

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

views: call UpdateAfterChange() in Textfield::InsertOrReplaceText(). The Omnibox uses InsertOrReplaceText() to implement its own paste handling that bypasses Textfield::OnPaste(), but the cursor still needs to be kept in sync with pastes. BUG=651016 Review-Url: https://codereview.chromium.org/2399863002 Cr-Commit-Position: refs/heads/master@{#423930} (cherry picked from commit cb06e3bec608cfc5f294d4aaa1a2c2e983017f05) Committed: https://chromium.googlesource.com/chromium/src/+/b2d6905a80d1603373c401558a145e195714938d

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -2 lines)			Patch
M	ui/views/controls/textfield/textfield.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/views/controls/textfield/textfield.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/views/controls/textfield/textfield_test_api.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/controls/textfield/textfield_unittest.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Elly Fong-Jones

4 years, 2 months ago (2016-10-12 20:41:29 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b2d6905a80d1603373c401558a145e195714938d.