Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2413033003: Fix product mode noSuchMethod with library prefix. (Closed)

Created:
4 years, 2 months ago by Florian Schneider
Modified:
4 years, 2 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix product mode noSuchMethod with library prefix. Update analyzer status of test that has a static warning expected. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/d9b1bc93af55ec6c482fceb51569b2b5c2cd1df5

Patch Set 1 #

Patch Set 2 : undo invalid fix, update status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/language/language.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Florian Schneider
4 years, 2 months ago (2016-10-13 00:50:56 UTC) #2
Florian Schneider
4 years, 2 months ago (2016-10-13 02:06:46 UTC) #4
siva
lgtm
4 years, 2 months ago (2016-10-13 02:07:34 UTC) #5
Florian Schneider
4 years, 2 months ago (2016-10-13 02:10:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d9b1bc93af55ec6c482fceb51569b2b5c2cd1df5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698