Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2413023003: Test that IncrementalCompilationUnitElementBuilder keeps elements in the same order as nodes. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test that IncrementalCompilationUnitElementBuilder keeps elements in the same order as nodes. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1f373db98e1be4779274b6b8bcab84949243e65a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -37 lines) Patch
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 20 chunks +121 lines, -37 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 2 months ago (2016-10-13 15:59:11 UTC) #1
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-10-13 16:02:52 UTC) #2
Paul Berry
lgtm
4 years, 2 months ago (2016-10-13 16:08:29 UTC) #3
scheglov
4 years, 2 months ago (2016-10-13 16:15:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f373db98e1be4779274b6b8bcab84949243e65a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698