promote SkImage::AlphaType to SkAlphaType

promote SkImage::AlphaType to SkAlphaType

BUG=
R=bsalomon@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11421

[reed1, 2013-09-20 17:49:50]

SkColorType is probably next, but I know for sure I want this for the unpremul
work

[bsalomon, 2013-09-20 19:09:30]

LGTM, just wondering if you want a more aggressive comment about
kUnpremul_SkAlphaType not being allowed for dsts. Maybe that's part of a later
change to SkBitmap.

[reed1, 2013-09-20 19:16:37]

skia.gyp will need to define SK_ENABLE_LEGACY_API_ALIASING until we can fix its
call-sites

./third_party/WebKit/Source/core/platform/graphics/chromium/Canvas2DLayerBridge.cpp:73:
   info.fAlphaType = SkImage::kPremul_AlphaType;
./third_party/WebKit/Source/core/platform/graphics/chromium/Canvas2DLayerBridgeTest.cpp:84:
           SkImage::kPremul_AlphaType,
./third_party/WebKit/Source/core/platform/graphics/chromium/Canvas2DLayerManagerTest.cpp:98:
       SkImage::kPremul_AlphaType,

[reed1, 2013-09-20 19:17:13]

On 2013/09/20 19:09:30, bsalomon wrote:
> LGTM, just wondering if you want a more aggressive comment about
> kUnpremul_SkAlphaType not being allowed for dsts. Maybe that's part of a later
> change to SkBitmap.

done

[reed1, 2013-09-20 19:36:24]

Committed patchset #3 manually as r11421 (presubmit successful).

[tfarina, 2013-09-20 21:54:21]

On 2013/09/20 19:16:37, reed1 wrote:
> skia.gyp will need to define SK_ENABLE_LEGACY_API_ALIASING until we can fix
its
> call-sites
> 
>
./third_party/WebKit/Source/core/platform/graphics/chromium/Canvas2DLayerBridge.cpp:73:
>    info.fAlphaType = SkImage::kPremul_AlphaType;
>
./third_party/WebKit/Source/core/platform/graphics/chromium/Canvas2DLayerBridgeTest.cpp:84:
>            SkImage::kPremul_AlphaType,
>
./third_party/WebKit/Source/core/platform/graphics/chromium/Canvas2DLayerManagerTest.cpp:98:
>        SkImage::kPremul_AlphaType,

Mike do you plan to go and fix Blink yourself? Let me know if I can help there.

Thanks!

[reed1, 2013-09-23 12:09:51]

On 2013/09/20 21:54:21, tfarina wrote:
> On 2013/09/20 19:16:37, reed1 wrote:
> > skia.gyp will need to define SK_ENABLE_LEGACY_API_ALIASING until we can fix
> its
> > call-sites
> > 
> >
>
./third_party/WebKit/Source/core/platform/graphics/chromium/Canvas2DLayerBridge.cpp:73:
> >    info.fAlphaType = SkImage::kPremul_AlphaType;
> >
>
./third_party/WebKit/Source/core/platform/graphics/chromium/Canvas2DLayerBridgeTest.cpp:84:
> >            SkImage::kPremul_AlphaType,
> >
>
./third_party/WebKit/Source/core/platform/graphics/chromium/Canvas2DLayerManagerTest.cpp:98:
> >        SkImage::kPremul_AlphaType,
> 
> Mike do you plan to go and fix Blink yourself? Let me know if I can help
there.
> 
> Thanks!

If you see the places to change in blink, that would be great!