Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: components/security_interstitials/core/browser/resources/interstitial_v2.js

Issue 2412993002: Make PEM debugging section fixed width in the SSL interstitial (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_interstitials/core/browser/resources/interstitial_v2.js
diff --git a/components/security_interstitials/core/browser/resources/interstitial_v2.js b/components/security_interstitials/core/browser/resources/interstitial_v2.js
index 332f6939fc340ff453158478974ec0693860c391..05ac2b864def7c8daf497c9b545616f21569d4c1 100644
--- a/components/security_interstitials/core/browser/resources/interstitial_v2.js
+++ b/components/security_interstitials/core/browser/resources/interstitial_v2.js
@@ -68,16 +68,21 @@ function handleKeypress(e) {
* (error-debugging-info) visible.
* @param {string} title The name of this debugging field.
* @param {string} value The value of the debugging field.
+ * @param {string=} extraCssClass Additional CSS classes. Optional.
*/
-function appendDebuggingField(title, value) {
+function appendDebuggingField(title, value, extraCssClass) {
// The values input here are not trusted. Never use innerHTML on these
// values!
var spanTitle = document.createElement('span');
spanTitle.classList.add('debugging-title');
+ spanTitle.classList.add('debugging-title');
lgarron 2016/10/12 19:43:37 Duplicate line?
meacer 2016/10/12 19:47:03 Done.
spanTitle.innerText = title + ': ';
var spanValue = document.createElement('span');
spanValue.classList.add('debugging-value');
+ if (extraCssClass) {
+ spanValue.classList.add(extraCssClass);
+ }
spanValue.innerText = value;
var pElem = document.createElement('p');

Powered by Google App Engine
This is Rietveld 408576698