Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2412983008: [ic] Move Smi-handler creation code to SmiHandler class. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Move Smi-handler creation code to SmiHandler class. ... to keep all the pieces in one place for easier modifications. This CL also adds a new runtime call stats bucket: KeyedLoadIC_LoadElementDH. BUG= Committed: https://crrev.com/ac886b0c1c173d6ceff762952e1d6cf78e8bd172 Cr-Commit-Position: refs/heads/master@{#40314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -28 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/counters.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/field-index.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/field-index-inl.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/ic/handler-compiler.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M src/ic/handler-configuration.h View 3 chunks +14 lines, -1 line 0 comments Download
A src/ic/handler-configuration-inl.h View 1 chunk +38 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-10-14 10:15:41 UTC) #5
Jakob Kummerow
lgtm
4 years, 2 months ago (2016-10-14 10:54:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412983008/1
4 years, 2 months ago (2016-10-14 12:24:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 12:37:13 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 12:37:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac886b0c1c173d6ceff762952e1d6cf78e8bd172
Cr-Commit-Position: refs/heads/master@{#40314}

Powered by Google App Engine
This is Rietveld 408576698