[Windows MSVC CFG] Add support for CFG, and enable on chrome.exe & chrome_elf.dll.

build/config/win/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/clang/clang.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/win/visual_studio_version.gni")
 import("//build/toolchain/toolchain.gni")
 
@@ skipping 246 matching lines @@
   }
 
   if (win_linker_timing) {
     ldflags += [
       "/time",
       "/verbose:incr",
     ]
   }
 }
 
+config("win_msvc_cfg") {

[scottmg, 2016/10/13 21:40:06]

Also a brief comment here with an MSDN link for those unfamiliar, as "CFG" is a
bit of a generic acronym.

[penny, 2016/10/13 22:08:30]

Done.

+  if (visual_studio_version == "2015" && !is_clang) {

[scottmg, 2016/10/13 21:38:12]

You can drop the version check, 2013 won't work for a lot of other reasons, and
I assume this will be supported for VS 2017 or whatever.

[penny, 2016/10/13 22:08:30]

Done.

+    cflags = [ "/guard:cf" ]
+  }
+
+  # /DYNAMICBASE (ASLR) is turned off in debug builds,
+  # therefore CFG can’t be turned on either.
+  if (!is_debug && !is_clang) {
+    ldflags = [ "/guard:cf" ]

[scottmg, 2016/10/13 21:38:12]

Doesn't seem much point in having /guard:cf passed to the compiler if it's not
passed to the linker. Just merge into one if?

[penny, 2016/10/13 22:08:30]

Done.

+  }
+}
+
 # CRT --------------------------------------------------------------------------
 
 # Configures how the runtime library (CRT) is going to be used.
 # See https://msdn.microsoft.com/en-us/library/2kzt1wy3.aspx for a reference of
 # what each value does.
 config("default_crt") {
   if (is_component_build) {
     # Component mode: dynamic CRT. Since the library is shared, it requires
     # exceptions or will give errors about things not matching, so keep
     # exceptions on.
@@ skipping 130 matching lines @@
 
 # Internal stuff --------------------------------------------------------------
 
 # Config used by the MIDL template to disable warnings.
 config("midl_warnings") {
   if (is_clang) {
     # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".
     cflags = [ "-Wno-extra-tokens" ]
   }
 }