Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2412983005: Reland of Disable service_worker.service_worker_micro_benchmark on Android WebView Perf (Closed)

Created:
4 years, 2 months ago by shimazu
Modified:
4 years, 2 months ago
Reviewers:
Zhen Wang, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Disable service_worker.service_worker_micro_benchmark on Android WebView Perf (patchset #1 id:1 of https://codereview.chromium.org/2412213002/ ) Reason for revert: This still breaks the tests. Original issue's description: > Revert of Disable service_worker.service_worker_micro_benchmark on Android WebView Perf (patchset #1 id:1 of https://codereview.chromium.org/2402703002/ ) > > Reason for revert: > The benchmark should be runnable on webview now. > > Original issue's description: > > Disable service_worker.service_worker_micro_benchmark on Android WebView Perf > > > > TBR=nednguyen@google.com > > BUG=chromium:653924 > > > > Committed: https://crrev.com/15ca7de391cdb9731e00426e9c524160ae2d7347 > > Cr-Commit-Position: refs/heads/master@{#424047} > > TBR=zhenw@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:653924 > > Committed: https://crrev.com/2b1cd31e7d0a45eac02a7fce8c792484f528b4cc > Cr-Commit-Position: refs/heads/master@{#424818} TBR=zhenw@chromium.org,nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:653924 Committed: https://crrev.com/ae502f1b55708a8501f40446ff6413cece546040 Cr-Commit-Position: refs/heads/master@{#424954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/perf/benchmarks/service_worker.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
shimazu
Created Reland of Disable service_worker.service_worker_micro_benchmark on Android WebView Perf
4 years, 2 months ago (2016-10-13 04:14:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412983005/1
4 years, 2 months ago (2016-10-13 04:14:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 04:15:14 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 04:17:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae502f1b55708a8501f40446ff6413cece546040
Cr-Commit-Position: refs/heads/master@{#424954}

Powered by Google App Engine
This is Rietveld 408576698