TaskScheduler: Put an ALIVE SchedulerWorker on top of the idle stack.

TaskScheduler: Put an ALIVE SchedulerWorker on top of the idle stack.

Before this CL, the initial state of the worker on top of the idle
stack was DETACHED while the initial state of the worker at the bottom
of the idle stack was ALIVE. The first task posted to the worker pool
woke up the DETACHED worker on top of the idle stack. When few tasks
were posted, the ALIVE worker at the bottom of the idle stack detached
without running a single task.

This CL makes the worker on top of the idle stack ALIVE and the worker
at the bottom of the idle stack DETACHED.

BUG=553459
Committed: https://crrev.com/08cf332fd47764c77a62fb6ebdeb88ff0ae17ede
Cr-Commit-Position: refs/heads/master@{#424908}

[fdoray, 2016-10-12 20:14:23]

fdoray@chromium.org changed reviewers:
+ robliao@chromium.org

[fdoray, 2016-10-12 20:14:24]

PTAL

[robliao, 2016-10-12 20:22:17]

lgtm

https://codereview.chromium.org/2412983003/diff/20001/base/task_scheduler/sch...
File base/task_scheduler/scheduler_worker_pool_impl.cc (right):

https://codereview.chromium.org/2412983003/diff/20001/base/task_scheduler/sch...
base/task_scheduler/scheduler_worker_pool_impl.cc:701: // The SchedulerWorker on
top of the idle stack is initially ALIVE.
Oops! Nice catch.

I would drive this home even more: The last added thread should be ALIVE.

[fdoray, 2016-10-12 21:18:44]

https://codereview.chromium.org/2412983003/diff/20001/base/task_scheduler/sch...
File base/task_scheduler/scheduler_worker_pool_impl.cc (right):

https://codereview.chromium.org/2412983003/diff/20001/base/task_scheduler/sch...
base/task_scheduler/scheduler_worker_pool_impl.cc:701: // The SchedulerWorker on
top of the idle stack is initially ALIVE.
On 2016/10/12 20:22:17, robliao wrote:
> Oops! Nice catch.
> 
> I would drive this home even more: The last added thread should be ALIVE.

Done.

[fdoray, 2016-10-12 21:18:55]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-10-12 21:18:56]

The patchset sent to the CQ was uploaded after l-g-t-m from robliao@chromium.org
Link to the patchset: https://codereview.chromium.org/2412983003/#ps40001
(title: "CR robliao #3")

[commit-bot: I haz the power, 2016-10-12 21:19:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 23:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 23:06:55]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[fdoray, 2016-10-12 23:10:53]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-10-12 23:11:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 23:45:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-12 23:47:06]

Description was changed from

==========
TaskScheduler: Put an ALIVE SchedulerWorker on top of the idle stack.

Before this CL, the initial state of the worker on top of the idle
stack was DETACHED while the initial state of the worker at the bottom
of the idle stack was ALIVE. The first task posted to the worker pool
woke up the DETACHED worker on top of the idle stack. When few tasks
were posted, the ALIVE worker at the bottom of the idle stack detached
without running a single task.

This CL makes the worker on top of the idle stack ALIVE and the worker
at the bottom of the idle stack DETACHED.

BUG=553459
==========

to

==========
TaskScheduler: Put an ALIVE SchedulerWorker on top of the idle stack.

Before this CL, the initial state of the worker on top of the idle
stack was DETACHED while the initial state of the worker at the bottom
of the idle stack was ALIVE. The first task posted to the worker pool
woke up the DETACHED worker on top of the idle stack. When few tasks
were posted, the ALIVE worker at the bottom of the idle stack detached
without running a single task.

This CL makes the worker on top of the idle stack ALIVE and the worker
at the bottom of the idle stack DETACHED.

BUG=553459

Committed: https://crrev.com/08cf332fd47764c77a62fb6ebdeb88ff0ae17ede
Cr-Commit-Position: refs/heads/master@{#424908}
==========

[commit-bot: I haz the power, 2016-10-12 23:47:06]

Patchset 3 (id:??) landed as
https://crrev.com/08cf332fd47764c77a62fb6ebdeb88ff0ae17ede
Cr-Commit-Position: refs/heads/master@{#424908}

[gab, 2016-10-17 16:41:59]

gab@chromium.org changed reviewers:
+ gab@chromium.org

[gab, 2016-10-17 16:42:00]

Nice catch :), lgtm