Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2412933002: [DevTools] use exposed from V8 v8_inspector_js_protocol in inspector BUILD.gn (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] use exposed from V8 v8_inspector_js_protocol in inspector BUILD.gn BUG=chromium:635948 R=dgozman@chromium.org Committed: https://crrev.com/8dcf2b50c84bc8f50f91ca8caacc411f8bed02ad Cr-Commit-Position: refs/heads/master@{#424968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/inspector/BUILD.gn View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kozy
Dmitry, please take a look!
4 years, 2 months ago (2016-10-12 17:28:22 UTC) #1
dgozman
Can we also easily fix one in inspector_protocol_config.json? lgtm
4 years, 2 months ago (2016-10-12 18:53:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412933002/1
4 years, 2 months ago (2016-10-13 05:18:04 UTC) #4
kozy
I'll try to fix this in followup.
4 years, 2 months ago (2016-10-13 05:19:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 06:33:46 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 06:37:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8dcf2b50c84bc8f50f91ca8caacc411f8bed02ad
Cr-Commit-Position: refs/heads/master@{#424968}

Powered by Google App Engine
This is Rietveld 408576698