Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2412903004: Revert of Make the CPDFXFA_App non-global (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Make the CPDFXFA_App non-global (patchset #3 id:80001 of https://codereview.chromium.org/2416753002/ ) Reason for revert: https://build.chromium.org/p/client.pdfium/builders/linux_xfa_asan_lsan/builds/112/steps/embeddertests/logs/stdio msan is sad. Original issue's description: > Make the CPDFXFA_App non-global > > This CL changes CPDFXFA_App from a global object to a child of the > CPDFXFA_Document objects. > > BUG=pdfium:623 > > Committed: https://pdfium.googlesource.com/pdfium/+/abefb79577b32d291d14d7e01a70f6f8cf213bd3 TBR=tsepez@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=pdfium:623 Committed: https://pdfium.googlesource.com/pdfium/+/b685e6471075bebd26711bc183de3128f54932e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -98 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_formfillenvironment.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M fpdfsdk/fpdfdoc_unittest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 4 chunks +14 lines, -11 lines 0 comments Download
M fpdfsdk/fpdfxfa/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_app.h View 2 chunks +14 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_app.cpp View 5 chunks +111 lines, -45 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_document.h View 5 chunks +11 lines, -6 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_document.cpp View 5 chunks +15 lines, -24 lines 0 comments Download
M fpdfsdk/javascript/cjs_runtime.cpp View 3 chunks +42 lines, -3 lines 0 comments Download
M fxjs/fxjs_v8.h View 1 chunk +7 lines, -0 lines 0 comments Download
M fxjs/fxjs_v8.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
Created Revert of Make the CPDFXFA_App non-global
4 years, 2 months ago (2016-10-13 17:56:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412903004/1
4 years, 2 months ago (2016-10-13 17:56:57 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 17:57:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/b685e6471075bebd26711bc183de3128f549...

Powered by Google App Engine
This is Rietveld 408576698