Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Issue 2412903003: [mac] Fixed window buttons positioning on Sierra. (Closed)

Created:
4 years, 2 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 2 months ago
Reviewers:
tapted
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mac] Fixed window buttons positioning on Sierra. Set buttons' bottomAnchor to superview bottomAnchor. BUG=655185, 605219 Committed: https://crrev.com/ba302109b0fafb5517c6ae29f5ae47735755c7da Cr-Commit-Position: refs/heads/master@{#424900}

Patch Set 1 #

Patch Set 2 : Fixed compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window.mm View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Eugene But (OOO till 7-30)
I don't have access to mac tree and could not tests this. Could you please ...
4 years, 2 months ago (2016-10-12 22:32:01 UTC) #10
tapted
lgtm - checked on 10.11 and a 10.12 VM - looks good! just a nit: ...
4 years, 2 months ago (2016-10-12 22:54:50 UTC) #11
Eugene But (OOO till 7-30)
Thanks! Updated BUG= line
4 years, 2 months ago (2016-10-12 23:08:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412903003/20001
4 years, 2 months ago (2016-10-12 23:08:36 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 23:13:40 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 23:17:18 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba302109b0fafb5517c6ae29f5ae47735755c7da
Cr-Commit-Position: refs/heads/master@{#424900}

Powered by Google App Engine
This is Rietveld 408576698