Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 2412853002: [crankshaft] Range analysis should not rely on overflowed ranges. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Range analysis should not rely on overflowed ranges. BUG=chromium:645438 Committed: https://crrev.com/9a0109d72e3dbbca282d39a5e401a3b61a2285e8 Cr-Commit-Position: refs/heads/master@{#40202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M src/crankshaft/hydrogen-instructions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 3 chunks +20 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-645438.js View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-10-12 08:16:58 UTC) #5
Benedikt Meurer
lgtm
4 years, 2 months ago (2016-10-12 08:28:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412853002/1
4 years, 2 months ago (2016-10-12 08:32:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 09:06:08 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 09:06:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a0109d72e3dbbca282d39a5e401a3b61a2285e8
Cr-Commit-Position: refs/heads/master@{#40202}

Powered by Google App Engine
This is Rietveld 408576698