Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Issue 2412833002: Optimize roll operator in CPDF_PSEngine. (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Optimize roll operator in CPDF_PSEngine. Rolling 0 times is a no-op. Rolling 0 items is a no-op. Rolling N items J times is the same as rolling N items J % N times. This also avoids an integer overflow corner case. BUG=chromium:648077 Committed: https://pdfium.googlesource.com/pdfium/+/47cbc06ef6f528e4d30a869ec533d010ee79b064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M core/fpdfapi/page/fpdf_page_func.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Lei Zhang
4 years, 2 months ago (2016-10-12 01:08:01 UTC) #6
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-12 16:04:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412833002/1
4 years, 2 months ago (2016-10-12 16:37:14 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 16:37:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/47cbc06ef6f528e4d30a869ec533d010ee79...

Powered by Google App Engine
This is Rietveld 408576698