Improve the page download:

chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc

Index: chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc b/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
index cc4073391d75fcc2f47f993882d30586a8e0cfca..8d484ebf20e18f4b72a6c5bd6c4b1c2743b0c034 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
+++ b/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
@@ -211,10 +211,8 @@ TEST_F(RecentTabHelperTest, Basic) {
 
 TEST_F(RecentTabHelperTest, SimpleCapture) {
   NavigateAndCommit(kTestPageUrl);
-  EXPECT_FALSE(recent_tab_helper()->is_page_ready_for_snapshot());
   recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
   RunUntilIdle();
-  EXPECT_TRUE(recent_tab_helper()->is_page_ready_for_snapshot());
   EXPECT_TRUE(model()->is_loaded());
   GetAllPages();
   EXPECT_EQ(1U, all_pages().size());
@@ -313,4 +311,20 @@ TEST_F(RecentTabHelperTest, FeatureNotEnabled) {
   EXPECT_EQ(0U, all_pages().size());
 }
 
+TEST_F(RecentTabHelperTest, DownloadRequest) {

[Pete Williamson, 2016/10/12 17:33:36]

Is it possible to add a test where you set up the request coordinator and then
call MarkRequestCompleted() to get the RC to resume a request?  Maybe that is
too difficult to test here, and needs to be added to the request coordinator
instead. 

[Dmitry Titov, 2016/10/12 23:11:14]

It should be a part of RequestCoordinator unittest... Is MarkRequestCompleted()
tested there?

[Pete Williamson, 2016/10/12 23:31:41]

Yes, but the test doesn't actually test that the request is resumed, that's more
of a system level test.

+  NavigateAndCommit(kTestPageUrl);
+  recent_tab_helper()->ObserveAndDownloadCurrentPage(
+      ClientId("download", "id1"), 153l);
+  recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
+  RunUntilIdle();
+  EXPECT_TRUE(model()->is_loaded());
+  GetAllPages();
+  EXPECT_EQ(1U, all_pages().size());
+  const OfflinePageItem& page = all_pages()[0];
+  EXPECT_EQ(kTestPageUrl, page.url);
+  EXPECT_EQ("download", page.client_id.name_space);
+  EXPECT_EQ("id1", page.client_id.id);
+  EXPECT_EQ(153l, page.offline_id);
+}
+
 }  // namespace offline_pages