Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2412773002: Merge "Keep reference to CDM to avoid it's premature destruction" (Closed)

Created:
4 years, 2 months ago by jrummell
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Merge "Keep reference to CDM to avoid it's premature destruction" Occassionally the CDM object is destroyed before the pipeline that uses it is stopped, so have WebMediaPlayerImpl keep a reference to it to prevent this from happening. This worked in the past as the pipeline was destroyed from HTMLMediaElement::stop() while the CDM was destroyed later from MediaKeys::contextDestroyed(). A recent change merged stop() and contextDestroyed(), so the CDM can be freed before WebMediaPlayerImpl is done with it. BUG=652978, 653001 TEST=EME layout tests pass Review-Url: https://codereview.chromium.org/2402563002 Cr-Commit-Position: refs/heads/master@{#424046} (cherry picked from commit e616ee95642ecc0b168a8e807abc86ff3633cda8) Committed: https://chromium.googlesource.com/chromium/src/+/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -39 lines) Patch
M media/blink/cdm_session_adapter.h View 1 chunk +2 lines, -4 lines 0 comments Download
M media/blink/cdm_session_adapter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmodule_impl.h View 2 chunks +3 lines, -5 lines 0 comments Download
M media/blink/webcontentdecryptionmodule_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 3 chunks +11 lines, -5 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 6 chunks +42 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jrummell
4 years, 2 months ago (2016-10-11 23:32:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6.

Powered by Google App Engine
This is Rietveld 408576698