Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2412763002: Revert of DevTools: archive content shell (Closed)

Created:
4 years, 2 months ago by chenwilliam
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ ) Reason for revert: Need to revert this b/c this CL is getting reverted: https://codereview.chromium.org/2407183003/ Original issue's description: > DevTools: archive content shell > > Creates an archive of the content shell for each desktop platform. > This will enable external contributors to use a precompiled > content shell to run devtools layout tests (and possibly others). > > The original patch broke the chrome archive because the FILES.cfg parser > couldn't support archiving the same file in multiple archives. > I've updated the parser logic in this CL: > > https://codereview.chromium.org/2402423002/ > > BUG=654486 > > Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf > Committed: https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35 > Cr-Original-Commit-Position: refs/heads/master@{#423195} > Cr-Commit-Position: refs/heads/master@{#424514} TBR=kerz@chromium.org,kerz@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=654486 Committed: https://crrev.com/943069059d70dff482b4f539a45da4aa28488d64 Cr-Commit-Position: refs/heads/master@{#424577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -196 lines) Patch
M chrome/tools/build/linux/FILES.cfg View 1 chunk +1 line, -86 lines 0 comments Download
M chrome/tools/build/mac/FILES.cfg View 1 chunk +0 lines, -49 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
chenwilliam
Created Revert of DevTools: archive content shell
4 years, 2 months ago (2016-10-11 22:35:48 UTC) #1
alph
lgtm
4 years, 2 months ago (2016-10-11 22:38:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412763002/1
4 years, 2 months ago (2016-10-11 22:40:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 22:41:49 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 22:50:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/943069059d70dff482b4f539a45da4aa28488d64
Cr-Commit-Position: refs/heads/master@{#424577}

Powered by Google App Engine
This is Rietveld 408576698