Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2412753002: Add UMA for documents calling window.print(). (Closed)
Patch Set: Add UMA for out-of-process iframes printing. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 032008b68c3031f8a39bd7f5a6a53beb16e8152f..c2fb3427f8896c3097114f976d63a7e1c6363625 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -47246,6 +47246,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Printing.InitiatedByScript" enum="BooleanMainFrame">
+ <owner>nasko@chromium.org</owner>
+ <summary>
+ Logged when a document calls the window.print() API. The boolean value
+ indicates whether it is invoked by the main frame. It will be false for
+ documents in subframes.
+ </summary>
+</histogram>
+
+<histogram name="Printing.OutOfProcessSubframe" enum="Boolean">
Alexei Svitkine (slow) 2016/10/12 20:59:47 Nit: Suggest adding a specific enum for this too.
Ilya Sherman 2016/10/12 21:45:54 As I mentioned on chat, it's probably more appropr
nasko 2016/10/12 21:58:04 I moved it to PrintPreview, as I think each invoca
+ <owner>nasko@chromium.org</owner>
+ <summary>
+ Logged when a document calls the window.print() API. The boolean value
+ indicates whether it is invoked by a subframe in a process different than
+ the top level frame.
Ilya Sherman 2016/10/12 21:45:54 Is this metric recorded only for subframes, or for
nasko 2016/10/12 21:58:04 Tried to reword a bit. Let me know if it is better
+ </summary>
+</histogram>
+
<histogram name="PrintPreview.DestinationAction"
enum="PrintPreviewPrintDestinationBuckets">
<owner>vitalybuka@chromium.org</owner>
@@ -73378,6 +73396,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="1" label="Loaded"/>
</enum>
+<enum name="BooleanMainFrame" type="int">
+ <int value="0" label="Subframe"/>
+ <int value="1" label="Main frame"/>
+</enum>
+
<enum name="BooleanMatched" type="int">
<int value="0" label="Not matched"/>
<int value="1" label="Matched"/>
« content/renderer/render_view_impl.cc ('K') | « content/renderer/render_view_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698