Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2412733002: Add FileDescriptorWatcher in LocalInputMonitorTest (Closed)

Created:
4 years, 2 months ago by Sergey Ulanov
Modified:
4 years, 2 months ago
Reviewers:
fdoray, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add FileDescriptorWatcher in LocalInputMonitorTest The test was failing without FileDescriptorWatcher. BUG=654895 Committed: https://crrev.com/36d99cbe255108f1b7358f122c1e8961112e7600 Cr-Commit-Position: refs/heads/master@{#424832}

Patch Set 1 #

Patch Set 2 : inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M remoting/host/local_input_monitor_unittest.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Sergey Ulanov
Do you know why it wasn't failing on the bots.
4 years, 2 months ago (2016-10-11 22:23:06 UTC) #2
fdoray
On 2016/10/11 22:23:06, Sergey Ulanov wrote: > Do you know why it wasn't failing on ...
4 years, 2 months ago (2016-10-12 13:17:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412733002/1
4 years, 2 months ago (2016-10-12 17:18:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/296598)
4 years, 2 months ago (2016-10-12 17:32:42 UTC) #7
fdoray
On 2016/10/12 17:32:42, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 2 months ago (2016-10-12 19:32:47 UTC) #8
fdoray
On 2016/10/12 19:32:47, fdoray wrote: > On 2016/10/12 17:32:42, commit-bot: I haz the power wrote: ...
4 years, 2 months ago (2016-10-12 19:34:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412733002/20001
4 years, 2 months ago (2016-10-12 19:46:05 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 20:06:28 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 20:12:15 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36d99cbe255108f1b7358f122c1e8961112e7600
Cr-Commit-Position: refs/heads/master@{#424832}

Powered by Google App Engine
This is Rietveld 408576698