Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2412653004: Disable BrowserTest.GetSizeForNewRenderView on Mac (Closed)

Created:
4 years, 2 months ago by msramek
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable BrowserTest.GetSizeForNewRenderView on Mac Broken in https://codereview.chromium.org/2404783002. TBR=sky@chromium.org BUG=655112 Committed: https://crrev.com/ede24242bd8b521e122812c3c703020840eac153 Cr-Commit-Position: refs/heads/master@{#424724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
msramek
Sheriff here disabling the test broken by https://codereview.chromium.org/2404783002 Adding author and reviewers as TBR, but ...
4 years, 2 months ago (2016-10-12 13:03:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412653004/1
4 years, 2 months ago (2016-10-12 13:03:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 13:17:49 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ede24242bd8b521e122812c3c703020840eac153 Cr-Commit-Position: refs/heads/master@{#424724}
4 years, 2 months ago (2016-10-12 13:20:56 UTC) #12
sky
If you know the patch that broke the test why didn't you revert the patch?
4 years, 2 months ago (2016-10-12 16:15:11 UTC) #13
Eugene But (OOO till 7-30)
4 years, 2 months ago (2016-10-12 21:40:00 UTC) #14
Message was sent while issue was closed.
On 2016/10/12 16:15:11, sky wrote:
> If you know the patch that broke the test why didn't you revert the patch?
I guess the problem is that the patch is not revertabe as subsequent changes in
the same file has landed.

Powered by Google App Engine
This is Rietveld 408576698