Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: runtime/vm/precompiler.cc

Issue 2412653002: VM Propagate receiver type from calls to unique selectors in AOT compilation. (Closed)
Patch Set: addressed comments, added test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | tests/language/vm/unique_selector_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/precompiler.cc
diff --git a/runtime/vm/precompiler.cc b/runtime/vm/precompiler.cc
index d55a6f10ce4bafd1e867ac513b912b6a04ac1e06..388db1a265d76e4a1c5ba5301f220d26104c7a7a 100644
--- a/runtime/vm/precompiler.cc
+++ b/runtime/vm/precompiler.cc
@@ -1495,8 +1495,7 @@ void Precompiler::CollectDynamicFunctionNames() {
}
}
- // Locate all entries with one function only, and whose owner is neither
- // subclassed nor implemented.
+ // Locate all entries with one function only
Table::Iterator iter(&table);
String& key = String::Handle(Z);
UniqueFunctionsSet functions_set(HashTables::New<UniqueFunctionsSet>(20));
@@ -1508,9 +1507,7 @@ void Precompiler::CollectDynamicFunctionNames() {
if (farray.Length() == 1) {
function ^= farray.At(0);
cls = function.Owner();
- if (!CHA::IsImplemented(cls) && !CHA::HasSubclasses(cls)) {
- functions_set.Insert(function);
- }
+ functions_set.Insert(function);
}
}
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | tests/language/vm/unique_selector_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698