Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2412623003: Rename cert_based_register_request to match server proto. (Closed)

Created:
4 years, 2 months ago by Thiemo Nagel
Modified:
4 years, 2 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename cert_based_register_request to match server proto. BUG=645078 Committed: https://crrev.com/82309f2139312d1de9968cec5c5a2251ec872306 Cr-Commit-Position: refs/heads/master@{#424714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/policy/test/policy_testserver.py View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_client_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/policy/proto/device_management_backend.proto View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Thiemo Nagel
Hi Roman, could you please take a look at that small change? Thank you! Thiemo
4 years, 2 months ago (2016-10-12 09:41:44 UTC) #4
Roman Sorokin (ftl)
On 2016/10/12 09:41:44, Thiemo Nagel (slow) wrote: > Hi Roman, > > could you please ...
4 years, 2 months ago (2016-10-12 09:48:58 UTC) #5
Thiemo Nagel
> lgtm > but could you add some context? Like server side bug or something. ...
4 years, 2 months ago (2016-10-12 11:23:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412623003/1
4 years, 2 months ago (2016-10-12 11:23:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 11:28:12 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 11:29:39 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82309f2139312d1de9968cec5c5a2251ec872306
Cr-Commit-Position: refs/heads/master@{#424714}

Powered by Google App Engine
This is Rietveld 408576698