Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2412623002: Reland "Move PathUtils to use ContextUtils." (Closed)

Created:
4 years, 2 months ago by Peter Wen
Modified:
4 years, 2 months ago
CC:
chromium-reviews, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, agrieve+watch_chromium.org, shaktisahu+watch-blimp_chromium.org, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, lcwu+watch_chromium.org, jam, gcasto+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, mlamouri+watch-content_chromium.org, halliwell+watch_chromium.org, Peter Beverloo, lizeb+watch-custom-tabs_chromium.org, alokp+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, android-webview-reviews_chromium.org, perumaal+watch-blimp_chromium.org, mikecase+watch_chromium.org, dtrainor+watch-blimp_chromium.org, jbudorick+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Move PathUtils to use ContextUtils." Revert for another issue required reverting original CL: https://codereview.chromium.org/2333713003/ CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=644377, 653711 TBR=slan@chromium.org,torne@chromium.org,agrieve@chromium.org,xunjieli@chromium.org,tedchoc@chromium.org,nyquist@chromium.org Committed: https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314 Cr-Commit-Position: refs/heads/master@{#424474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -80 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java View 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java View 3 chunks +3 lines, -5 lines 0 comments Download
M base/android/java/src/org/chromium/base/BaseChromiumApplication.java View 2 chunks +2 lines, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/PathUtils.java View 3 chunks +12 lines, -15 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/BlimpApplication.java View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java View 2 chunks +8 lines, -5 lines 0 comments Download
M components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java View 9 chunks +12 lines, -5 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java View 2 chunks +3 lines, -1 line 0 comments Download
M components/invalidation/impl/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java View 2 chunks +2 lines, -4 lines 0 comments Download
M components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java View 1 chunk +6 lines, -5 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/NativeLibraryTestBase.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java View 1 chunk +5 lines, -8 lines 0 comments Download
M content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java View 1 chunk +4 lines, -7 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java View 2 chunks +6 lines, -8 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTest.java View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412623002/1
4 years, 2 months ago (2016-10-11 16:55:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 17:41:13 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:43:39 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314
Cr-Commit-Position: refs/heads/master@{#424474}

Powered by Google App Engine
This is Rietveld 408576698