Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2412613007: Suppress embedded object output and flush load complete output (Closed)

Created:
4 years, 2 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress embedded object output and flush load complete output - Reading the embeddedObject role (not localized) is uneeded noise. - load completes should always interrupt other output (including utterances left over from the previous page). BUG=620744, 540800 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c40225d7f02bbc60b8b761631368dd1de0c25b40 Cr-Commit-Position: refs/heads/master@{#425377}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
David Tseng
4 years, 2 months ago (2016-10-12 22:32:48 UTC) #4
dmazzoni
lgtm https://codereview.chromium.org/2412613007/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js (right): https://codereview.chromium.org/2412613007/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js#newcode452 chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:452: embeddedObject: { nit: indentation
4 years, 2 months ago (2016-10-14 07:26:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412613007/20001
4 years, 2 months ago (2016-10-14 15:14:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 17:35:46 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 17:40:08 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c40225d7f02bbc60b8b761631368dd1de0c25b40
Cr-Commit-Position: refs/heads/master@{#425377}

Powered by Google App Engine
This is Rietveld 408576698