Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2412613005: Removed makeLinearGamma() from the public API for SkColorSpace (Closed)

Created:
4 years, 2 months ago by raftias
Modified:
4 years, 2 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Removed makeLinearGamma() from the public API for SkColorSpace It will now reside in SkColorSpace_Base. Future work for SkColorSpace will cause this function to not be desirable or sensible to call on all SkColorSpaces. Call sites were changed to make a kSRGBLinear_Named instead of kSRGB_Named -> makeLinearGamma() (the majority of cases), and if that was not possible, SkColorSpace_Base::makeLinearGamma() was called instead. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2412613005 Committed: https://skia.googlesource.com/skia/+/7c602de058c6332dfd92b70a3d05d4a3c401a3ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -30 lines) Patch
M bench/ColorCodecBench.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M bench/nanobench.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M dm/DM.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gamut.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M gm/gradients.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M gyp/flags.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkColorSpace.h View 1 chunk +0 lines, -5 lines 0 comments Download
M samplecode/SampleApp.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/core/SkColorSpace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkColorSpace_Base.h View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/CodecTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M tests/ColorSpaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M tools/skiaserve/Request.cpp View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
raftias
4 years, 2 months ago (2016-10-12 21:19:14 UTC) #8
msarett
lgtm
4 years, 2 months ago (2016-10-13 17:13:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412613005/1
4 years, 2 months ago (2016-10-13 17:13:47 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 17:45:47 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7c602de058c6332dfd92b70a3d05d4a3c401a3ae

Powered by Google App Engine
This is Rietveld 408576698