Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Issue 2412603002: archive recipe_module: Add missing dependency (Closed)

Created:
4 years, 2 months ago by Oliver Chang
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M scripts/slave/recipe_modules/archive/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Oliver Chang
ptal, trivial change. This is to fix: ModuleInjectionError: Recipe Module 'archive' has no dependency 'step'. ...
4 years, 2 months ago (2016-10-11 16:45:03 UTC) #2
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-11 17:11:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412603002/1
4 years, 2 months ago (2016-10-11 17:54:36 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:58:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/d75a2a6c28a5a5d52e4f...

Powered by Google App Engine
This is Rietveld 408576698