Use CreateProcess instead of subprocess.Popen to launch Chrome in the mini_installer test framework.

chrome/test/mini_installer/launch_chrome.py

Index: chrome/test/mini_installer/launch_chrome.py
diff --git a/chrome/test/mini_installer/launch_chrome.py b/chrome/test/mini_installer/launch_chrome.py
index 311a06b37aa7021afe8431c2c5fa519793a055c6..b85c555a1c8662db4c41c941d4f6df17da9c4c03 100644
--- a/chrome/test/mini_installer/launch_chrome.py
+++ b/chrome/test/mini_installer/launch_chrome.py
@@ -8,9 +8,9 @@ This script launches Chrome and waits until its window shows up.
 """
 
 import optparse
-import subprocess
 import sys
 import time
+import win32process
 
 import chrome_helper
 
@@ -42,8 +42,10 @@ def main():
     parser.error('Incorrect number of arguments.')
   chrome_path = args[0]
 
-  process = subprocess.Popen(chrome_path)
-  if not WaitForWindow(process.pid, 'Chrome_WidgetWin_'):
+  _, _, process_id, _ = win32process.CreateProcess(None, chrome_path, None,

[gab, 2013/09/19 18:22:11]

Add a comment here as to why we use CreateProcess.

Otherwise lgtm!

[sukolsak, 2013/09/19 20:23:09]

Done. Thank you.

+                                                   None, 0, 0, None, None,
+                                                   win32process.STARTUPINFO())
+  if not WaitForWindow(process_id, 'Chrome_WidgetWin_'):
     raise Exception('Could not launch Chrome.')
   return 0