Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: services/ui/public/interfaces/ime.mojom

Issue 2412593002: IME for Mus: Send ack for key events after IME driver processes the event. (Closed)
Patch Set: Addressed feedback. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/ime/test_ime_driver/test_ime_driver.cc ('k') | ui/views/mus/input_method_mus.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/public/interfaces/ime.mojom
diff --git a/services/ui/public/interfaces/ime.mojom b/services/ui/public/interfaces/ime.mojom
index 17d91070c30454fac083725453fa53e9d2f9559c..af86e21106fbd5a61000072b52704f35c104b457 100644
--- a/services/ui/public/interfaces/ime.mojom
+++ b/services/ui/public/interfaces/ime.mojom
@@ -93,11 +93,11 @@ interface InputMethod {
// Mus translates it to global coordinates and sends it to IME app.
OnCaretBoundsChanged(gfx.mojom.Rect caret_bounds);
- // Called to process a key event. If InputMethod handles the event, it will
- // notify the client of the resulting composition events (there might be none)
- // by calling TextInputClient::OnCompositionEvent(). If the event is not
- // handled by InputMethod, TextInputClient::OnUnhandledEvent() is called.
- ProcessKeyEvent(ui.mojom.Event key_event);
+ // Called to process a key event. The callback function will be called to
+ // notify the client if the event was handled or not. A handled event may
+ // generate zero or more composition events which will be sent to the client
+ // by calling TextInputClient::OnCompositionEvent().
+ ProcessKeyEvent(ui.mojom.Event key_event) => (bool handled);
CancelComposition();
};
@@ -108,9 +108,6 @@ interface TextInputClient {
// See comments for InputMethod::ProcessKeyEvent() for when this is called.
OnCompositionEvent(CompositionEvent event);
- // See comments for InputMethod::ProcessKeyEvent() for when this is called.
- OnUnhandledEvent(ui.mojom.Event key_event);
-
// TODO(moshayedi): Add functions corresponding to ui::TextInputClient for:
// - Input text confirmation
// - Document content operations
« no previous file with comments | « services/ui/ime/test_ime_driver/test_ime_driver.cc ('k') | ui/views/mus/input_method_mus.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698