Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp

Issue 2412523002: Cleanup env variable names (Closed)
Patch Set: Cleanup Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« fpdfsdk/fpdfformfill.cpp ('K') | « fpdfsdk/fpdfxfa/cpdfxfa_app.cpp ('k') | fpdfsdk/fpdfxfa/cpdfxfa_document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp
diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp
index 8ac4423ca30b564a48998fef0e5dd960bc2bd1a5..5e76c550e294d98d831368ea30b32c7c4a1a374d 100644
--- a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp
+++ b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp
@@ -46,7 +46,7 @@ CPDFXFA_DocEnvironment::~CPDFXFA_DocEnvironment() {
void CPDFXFA_DocEnvironment::SetChangeMark(CXFA_FFDoc* hDoc) {
if (hDoc == m_pDocument->GetXFADoc() && m_pDocument->GetFormFillEnv())
- m_pDocument->GetFormFillEnv()->GetSDKDocument()->SetChangeMark();
+ m_pDocument->GetFormFillEnv()->SetChangeMark();
}
void CPDFXFA_DocEnvironment::InvalidateRect(CXFA_FFPageView* pPageView,
@@ -278,7 +278,7 @@ void CPDFXFA_DocEnvironment::PageViewEvent(CXFA_FFPageView* pPageView,
if (!pPage)
continue;
- m_pDocument->GetFormFillEnv()->GetSDKDocument()->RemovePageView(pPage);
+ m_pDocument->GetFormFillEnv()->RemovePageView(pPage);
pPage->SetXFAPageView(pXFADocView->GetPageView(iPageIter));
}
@@ -304,7 +304,6 @@ void CPDFXFA_DocEnvironment::WidgetPostAdd(CXFA_FFWidget* hWidget,
return;
m_pDocument->GetFormFillEnv()
- ->GetSDKDocument()
->GetPageView(pXFAPage, true)
->AddAnnot(hWidget);
}
@@ -323,8 +322,7 @@ void CPDFXFA_DocEnvironment::WidgetPreRemove(CXFA_FFWidget* hWidget,
return;
CPDFSDK_PageView* pSdkPageView =
- m_pDocument->GetFormFillEnv()->GetSDKDocument()->GetPageView(pXFAPage,
- true);
+ m_pDocument->GetFormFillEnv()->GetPageView(pXFAPage, true);
if (CPDFSDK_Annot* pAnnot = pSdkPageView->GetAnnotByXFAWidget(hWidget))
pSdkPageView->DeleteAnnot(pAnnot);
}
@@ -352,8 +350,7 @@ void CPDFXFA_DocEnvironment::SetCurrentPage(CXFA_FFDoc* hDoc,
int32_t iCurPage) {
if (hDoc != m_pDocument->GetXFADoc() || !m_pDocument->GetFormFillEnv() ||
m_pDocument->GetDocType() != DOCTYPE_DYNAMIC_XFA || iCurPage < 0 ||
- iCurPage >=
- m_pDocument->GetFormFillEnv()->GetSDKDocument()->GetPageCount()) {
+ iCurPage >= m_pDocument->GetFormFillEnv()->GetPageCount()) {
return;
}
@@ -366,11 +363,11 @@ void CPDFXFA_DocEnvironment::SetCurrentPage(CXFA_FFDoc* hDoc,
FX_BOOL CPDFXFA_DocEnvironment::IsCalculationsEnabled(CXFA_FFDoc* hDoc) {
if (hDoc != m_pDocument->GetXFADoc() || !m_pDocument->GetFormFillEnv())
return FALSE;
- if (m_pDocument->GetFormFillEnv()->GetSDKDocument()->GetInterForm())
+ if (m_pDocument->GetFormFillEnv()->GetInterForm()) {
return m_pDocument->GetFormFillEnv()
- ->GetSDKDocument()
->GetInterForm()
->IsXfaCalculateEnabled();
+ }
return FALSE;
}
@@ -378,11 +375,11 @@ void CPDFXFA_DocEnvironment::SetCalculationsEnabled(CXFA_FFDoc* hDoc,
FX_BOOL bEnabled) {
if (hDoc != m_pDocument->GetXFADoc() || !m_pDocument->GetFormFillEnv())
return;
- if (m_pDocument->GetFormFillEnv()->GetSDKDocument()->GetInterForm())
+ if (m_pDocument->GetFormFillEnv()->GetInterForm()) {
m_pDocument->GetFormFillEnv()
- ->GetSDKDocument()
->GetInterForm()
->XfaEnableCalculate(bEnabled);
+ }
}
void CPDFXFA_DocEnvironment::GetTitle(CXFA_FFDoc* hDoc,
@@ -415,8 +412,9 @@ void CPDFXFA_DocEnvironment::ExportData(CXFA_FFDoc* hDoc,
return;
if (m_pDocument->GetDocType() != DOCTYPE_DYNAMIC_XFA &&
- m_pDocument->GetDocType() != DOCTYPE_STATIC_XFA)
+ m_pDocument->GetDocType() != DOCTYPE_STATIC_XFA) {
return;
+ }
CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pDocument->GetFormFillEnv();
if (!pFormFillEnv)
@@ -527,11 +525,11 @@ void CPDFXFA_DocEnvironment::GotoURL(CXFA_FFDoc* hDoc,
FX_BOOL CPDFXFA_DocEnvironment::IsValidationsEnabled(CXFA_FFDoc* hDoc) {
if (hDoc != m_pDocument->GetXFADoc() || !m_pDocument->GetFormFillEnv())
return FALSE;
- if (m_pDocument->GetFormFillEnv()->GetSDKDocument()->GetInterForm())
+ if (m_pDocument->GetFormFillEnv()->GetInterForm()) {
return m_pDocument->GetFormFillEnv()
- ->GetSDKDocument()
->GetInterForm()
->IsXfaValidationsEnabled();
+ }
return TRUE;
}
@@ -539,11 +537,11 @@ void CPDFXFA_DocEnvironment::SetValidationsEnabled(CXFA_FFDoc* hDoc,
FX_BOOL bEnabled) {
if (hDoc != m_pDocument->GetXFADoc() || !m_pDocument->GetFormFillEnv())
return;
- if (m_pDocument->GetFormFillEnv()->GetSDKDocument()->GetInterForm())
+ if (m_pDocument->GetFormFillEnv()->GetInterForm()) {
m_pDocument->GetFormFillEnv()
- ->GetSDKDocument()
->GetInterForm()
->XfaSetValidationsEnabled(bEnabled);
+ }
}
void CPDFXFA_DocEnvironment::SetFocusWidget(CXFA_FFDoc* hDoc,
@@ -553,21 +551,19 @@ void CPDFXFA_DocEnvironment::SetFocusWidget(CXFA_FFDoc* hDoc,
if (!hWidget) {
CPDFSDK_Annot::ObservedPtr pNull;
- m_pDocument->GetFormFillEnv()->GetSDKDocument()->SetFocusAnnot(&pNull);
+ m_pDocument->GetFormFillEnv()->SetFocusAnnot(&pNull);
return;
}
- int pageViewCount =
- m_pDocument->GetFormFillEnv()->GetSDKDocument()->GetPageViewCount();
+ int pageViewCount = m_pDocument->GetFormFillEnv()->GetPageViewCount();
for (int i = 0; i < pageViewCount; i++) {
- CPDFSDK_PageView* pPageView =
- m_pDocument->GetFormFillEnv()->GetSDKDocument()->GetPageView(i);
+ CPDFSDK_PageView* pPageView = m_pDocument->GetFormFillEnv()->GetPageView(i);
if (!pPageView)
continue;
CPDFSDK_Annot::ObservedPtr pAnnot(pPageView->GetAnnotByXFAWidget(hWidget));
if (pAnnot) {
- m_pDocument->GetFormFillEnv()->GetSDKDocument()->SetFocusAnnot(&pAnnot);
+ m_pDocument->GetFormFillEnv()->SetFocusAnnot(&pAnnot);
break;
}
}
@@ -599,8 +595,7 @@ FX_ARGB CPDFXFA_DocEnvironment::GetHighlightColor(CXFA_FFDoc* hDoc) {
if (hDoc != m_pDocument->GetXFADoc() || !m_pDocument->GetFormFillEnv())
return 0;
- CPDFSDK_InterForm* pInterForm =
- m_pDocument->GetFormFillEnv()->GetSDKDocument()->GetInterForm();
+ CPDFSDK_InterForm* pInterForm = m_pDocument->GetFormFillEnv()->GetInterForm();
if (!pInterForm)
return 0;
« fpdfsdk/fpdfformfill.cpp ('K') | « fpdfsdk/fpdfxfa/cpdfxfa_app.cpp ('k') | fpdfsdk/fpdfxfa/cpdfxfa_document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698