Cleanup env variable names

fpdfsdk/fpdfxfa/cpdfxfa_app.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/fpdfxfa/cpdfxfa_app.h"
 
 #include <memory>
 
@@ skipping 20 matching lines @@
 
 void CPDFXFA_App::ReleaseInstance() {
   delete g_pApp;
   g_pApp = nullptr;
 }
 
 CPDFXFA_App::CPDFXFA_App()
     : m_bJavaScriptInitialized(FALSE),
       m_pIsolate(nullptr),
       m_csAppType(JS_STR_VIEWERTYPE_STANDARD) {
-  m_pEnvList.RemoveAll();
+  m_pFormFillEnvList.RemoveAll();
 }
 
 CPDFXFA_App::~CPDFXFA_App() {
   FXJSE_Runtime_Release(m_pIsolate);
   m_pIsolate = nullptr;
 
   FXJSE_Finalize();
   BC_Library_Destory();
 }
 
 FX_BOOL CPDFXFA_App::Initialize(v8::Isolate* pIsolate) {
   BC_Library_Init();
   FXJSE_Initialize();
 
   m_pIsolate = pIsolate ? pIsolate : FXJSE_Runtime_Create_Own();
   if (!m_pIsolate)
     return FALSE;
 
   m_pXFAApp = pdfium::MakeUnique<CXFA_FFApp>(this);
   m_pXFAApp->SetDefaultFontMgr(
       std::unique_ptr<CXFA_DefFontMgr>(new CXFA_DefFontMgr));
 
   return TRUE;
 }
 
-FX_BOOL CPDFXFA_App::AddFormFillEnv(CPDFSDK_FormFillEnvironment* pEnv) {
-  if (!pEnv)
+FX_BOOL CPDFXFA_App::AddFormFillEnv(CPDFSDK_FormFillEnvironment* pFormFillEnv) {
+  if (!pFormFillEnv)
     return FALSE;
 
-  m_pEnvList.Add(pEnv);
+  m_pFormFillEnvList.Add(pFormFillEnv);
   return TRUE;
 }
 
-FX_BOOL CPDFXFA_App::RemoveFormFillEnv(CPDFSDK_FormFillEnvironment* pEnv) {
-  if (!pEnv)
+FX_BOOL CPDFXFA_App::RemoveFormFillEnv(
+    CPDFSDK_FormFillEnvironment* pFormFillEnv) {
+  if (!pFormFillEnv)
     return FALSE;
 
-  int nFind = m_pEnvList.Find(pEnv);
+  int nFind = m_pFormFillEnvList.Find(pFormFillEnv);
   if (nFind != -1) {
-    m_pEnvList.RemoveAt(nFind);
+    m_pFormFillEnvList.RemoveAt(nFind);
     return TRUE;
   }
 
   return FALSE;
 }
 
 void CPDFXFA_App::GetAppType(CFX_WideString& wsAppType) {
   wsAppType = m_csAppType;
 }
 
 void CPDFXFA_App::GetAppName(CFX_WideString& wsName) {
-  CPDFSDK_FormFillEnvironment* pEnv = m_pEnvList.GetAt(0);
-  if (pEnv) {
-    wsName = pEnv->FFI_GetAppName();
-  }
+  CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pFormFillEnvList.GetAt(0);
+  if (pFormFillEnv)
+    wsName = pFormFillEnv->FFI_GetAppName();
 }
 
 void CPDFXFA_App::SetAppType(const CFX_WideStringC& wsAppType) {
   m_csAppType = wsAppType;
 }
 
 void CPDFXFA_App::GetLanguage(CFX_WideString& wsLanguage) {
-  CPDFSDK_FormFillEnvironment* pEnv = m_pEnvList.GetAt(0);
-  if (pEnv)
-    wsLanguage = pEnv->GetLanguage();
+  CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pFormFillEnvList.GetAt(0);
+  if (pFormFillEnv)
+    wsLanguage = pFormFillEnv->GetLanguage();
 }
 
 void CPDFXFA_App::GetPlatform(CFX_WideString& wsPlatform) {
-  CPDFSDK_FormFillEnvironment* pEnv = m_pEnvList.GetAt(0);
-  if (pEnv) {
-    wsPlatform = pEnv->GetPlatform();
+  CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pFormFillEnvList.GetAt(0);
+  if (pFormFillEnv) {
+    wsPlatform = pFormFillEnv->GetPlatform();
   }
 }
 
 void CPDFXFA_App::GetVariation(CFX_WideString& wsVariation) {
   wsVariation = JS_STR_VIEWERVARIATION;
 }
 
 void CPDFXFA_App::GetVersion(CFX_WideString& wsVersion) {
   wsVersion = JS_STR_VIEWERVERSION_XFA;
 }
 
 void CPDFXFA_App::Beep(uint32_t dwType) {
-  CPDFSDK_FormFillEnvironment* pEnv = m_pEnvList.GetAt(0);
-  if (pEnv) {
-    pEnv->JS_appBeep(dwType);
+  CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pFormFillEnvList.GetAt(0);
+  if (pFormFillEnv) {
+    pFormFillEnv->JS_appBeep(dwType);
   }
 }
 
 int32_t CPDFXFA_App::MsgBox(const CFX_WideString& wsMessage,
                             const CFX_WideString& wsTitle,
                             uint32_t dwIconType,
                             uint32_t dwButtonType) {
-  CPDFSDK_FormFillEnvironment* pEnv = m_pEnvList.GetAt(0);
-  if (!pEnv)
+  CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pFormFillEnvList.GetAt(0);
+  if (!pFormFillEnv)
     return -1;
 
   uint32_t iconType = 0;
   int iButtonType = 0;
   switch (dwIconType) {
     case XFA_MBICON_Error:
       iconType |= 0;
       break;
     case XFA_MBICON_Warning:
       iconType |= 1;
@@ skipping 12 matching lines @@
     case XFA_MB_OKCancel:
       iButtonType |= 1;
       break;
     case XFA_MB_YesNo:
       iButtonType |= 2;
       break;
     case XFA_MB_YesNoCancel:
       iButtonType |= 3;
       break;
   }
-  int32_t iRet = pEnv->JS_appAlert(wsMessage.c_str(), wsTitle.c_str(),
-                                   iButtonType, iconType);
+  int32_t iRet = pFormFillEnv->JS_appAlert(wsMessage.c_str(), wsTitle.c_str(),
+                                           iButtonType, iconType);
   switch (iRet) {
     case 1:
       return XFA_IDOK;
     case 2:
       return XFA_IDCancel;
     case 3:
       return XFA_IDNo;
     case 4:
       return XFA_IDYes;
   }
   return XFA_IDYes;
 }
 
 CFX_WideString CPDFXFA_App::Response(const CFX_WideString& wsQuestion,
                                      const CFX_WideString& wsTitle,
                                      const CFX_WideString& wsDefaultAnswer,
                                      FX_BOOL bMark) {
   CFX_WideString wsAnswer;
-  CPDFSDK_FormFillEnvironment* pEnv = m_pEnvList.GetAt(0);
-  if (pEnv) {
+  CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pFormFillEnvList.GetAt(0);
+  if (pFormFillEnv) {
     int nLength = 2048;
     char* pBuff = new char[nLength];
-    nLength = pEnv->JS_appResponse(wsQuestion.c_str(), wsTitle.c_str(),
-                                   wsDefaultAnswer.c_str(), nullptr, bMark,
-                                   pBuff, nLength);
+    nLength = pFormFillEnv->JS_appResponse(wsQuestion.c_str(), wsTitle.c_str(),
+                                           wsDefaultAnswer.c_str(), nullptr,
+                                           bMark, pBuff, nLength);
     if (nLength > 0) {
       nLength = nLength > 2046 ? 2046 : nLength;
       pBuff[nLength] = 0;
       pBuff[nLength + 1] = 0;
       wsAnswer = CFX_WideString::FromUTF16LE(
           reinterpret_cast<const unsigned short*>(pBuff),
           nLength / sizeof(unsigned short));
     }
     delete[] pBuff;
   }
   return wsAnswer;
 }
 
 IFX_FileRead* CPDFXFA_App::DownloadURL(const CFX_WideString& wsURL) {
-  CPDFSDK_FormFillEnvironment* pEnv = m_pEnvList.GetAt(0);
-  return pEnv ? pEnv->DownloadFromURL(wsURL.c_str()) : nullptr;
+  CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pFormFillEnvList.GetAt(0);
+  return pFormFillEnv ? pFormFillEnv->DownloadFromURL(wsURL.c_str()) : nullptr;
 }
 
 FX_BOOL CPDFXFA_App::PostRequestURL(const CFX_WideString& wsURL,
                                     const CFX_WideString& wsData,
                                     const CFX_WideString& wsContentType,
                                     const CFX_WideString& wsEncode,
                                     const CFX_WideString& wsHeader,
                                     CFX_WideString& wsResponse) {
-  CPDFSDK_FormFillEnvironment* pEnv = m_pEnvList.GetAt(0);
-  if (!pEnv)
+  CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pFormFillEnvList.GetAt(0);
+  if (!pFormFillEnv)
     return FALSE;
 
-  wsResponse =
-      pEnv->PostRequestURL(wsURL.c_str(), wsData.c_str(), wsContentType.c_str(),
-                           wsEncode.c_str(), wsHeader.c_str());
+  wsResponse = pFormFillEnv->PostRequestURL(wsURL.c_str(), wsData.c_str(),
+                                            wsContentType.c_str(),
+                                            wsEncode.c_str(), wsHeader.c_str());
   return TRUE;
 }
 
 FX_BOOL CPDFXFA_App::PutRequestURL(const CFX_WideString& wsURL,
                                    const CFX_WideString& wsData,
                                    const CFX_WideString& wsEncode) {
-  CPDFSDK_FormFillEnvironment* pEnv = m_pEnvList.GetAt(0);
-  return pEnv &&
-         pEnv->PutRequestURL(wsURL.c_str(), wsData.c_str(), wsEncode.c_str());
+  CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pFormFillEnvList.GetAt(0);
+  return pFormFillEnv &&
+         pFormFillEnv->PutRequestURL(wsURL.c_str(), wsData.c_str(),
+                                     wsEncode.c_str());
 }
 
 void CPDFXFA_App::LoadString(int32_t iStringID, CFX_WideString& wsString) {
   switch (iStringID) {
     case XFA_IDS_ValidateFailed:
       wsString = L"%s validation failed";
       return;
     case XFA_IDS_CalcOverride:
       wsString = L"Calculate Override";
       return;
@@ skipping 81 matching lines @@
           L"%s, click Ignore.";
       return;
     case XFA_IDS_ValidateError:
       wsString = L"The value you entered for %s is invalid.";
       return;
   }
 }
 
 IFWL_AdapterTimerMgr* CPDFXFA_App::GetTimerMgr() {
   CXFA_FWLAdapterTimerMgr* pAdapter = nullptr;
-  CPDFSDK_FormFillEnvironment* pEnv = m_pEnvList.GetAt(0);
-  if (pEnv)
-    pAdapter = new CXFA_FWLAdapterTimerMgr(pEnv);
+  CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pFormFillEnvList.GetAt(0);
+  if (pFormFillEnv)
+    pAdapter = new CXFA_FWLAdapterTimerMgr(pFormFillEnv);
   return pAdapter;
 }